The ibm-platform-lsf-master charm should unregister from cluster on remove-unit

[Matt Bruzek]

When removing a unit the ibm-platform-lsf-master charm does not remove the configuration from the lsf cluster. Juju removes the VM from the model, but the lsf cluster still thinks it has 2 hosts.

Here are the commands that I ran:

(set up two ibm-platform-lsf-master with ibm-platform-lsf-storage per README.md)

juju remove-unit ibm-platform-lsf-master/1
(and I watched the Juju VM get removed from Amazon)

lsfadmin@ip-172-31-17-201:/usr/share/lsf/9.1/linux2.6-glibc2.3-x86_64/bin$ lsclusters
CLUSTER_NAME STATUS MASTER_HOST ADMIN HOSTS SERVERS
cluster1 ok ip-172-31-17-201 lsfadmin 2 2
lsfadmin@ip-172-31-17-201:/usr/share/lsf/9.1/linux2.6-glibc2.3-x86_64/bin$ bhosts
HOST_NAME STATUS JL/U MAX NJOBS RUN SSUSP USUSP RSV
ip-172-31-17-201 ok - 1 0 0 0 0 0
ip-172-31-2-190 ok - 1 0 0 0 0 0

At this point the cluster still thinks it has 2 cluster but the VM is gone!

lsfadmin@ip-172-31-17-201:/usr/share/lsf/9.1/linux2.6-glibc2.3-x86_64/bin$ lshosts
HOST_NAME type model cpuf ncpus maxmem maxswp server RESOURCES
ip-172-31-1 X86_64 Intel_EM 60.0 1 3.6G - Yes (mg)
ip-172-31-2 X86_64 Intel_EM 60.0 - - - Yes (mg)
lsfadmin@ip-172-31-17-201:/usr/share/lsf/9.1/linux2.6-glibc2.3-x86_64/bin$ bhosts
HOST_NAME STATUS JL/U MAX NJOBS RUN SSUSP USUSP RSV
ip-172-31-17-201 ok - 1 0 0 0 0 0
ip-172-31-2-190 unavail - 1 0 0 0 0 0

You can see the cluster still thinks it has another host. The reactive code should be updated to remove the configuration from the lsf cluster before the charm goes away or departs.