Initial Commit for Interface of IBM-MQ

[Anita Nayak]

Hi All,
Here is a new Interface for IBM MQ for review.

Interface used for IBM MQ

The consumer charms can use ibm-mq interface to connect to ibm-mq charm.

The code can be found in the below link:
https://code.launchpad.net/~ibmcharmers/interface-ibm-mq/trunk

Thanks

[Kevin W Monroe (kwmonroe)]

Hi Anita, this looks like it will work as written, but I have a few comments that might help ease future maintenance:

REQUIRES.PY:
I noticed a few '.available' state references, for example:

http://bazaar.launchpad.net/~ibmcharmers/interface-ibm-mq/trunk/view/head:/requires.py?start_revid=1

The only states used by charms that leverage this interface are '.connected' and '.ready'. Therefore, references to '.available' should be removed, along with the debug "print('foo')" statements.

PROVIDES.PY:
The auto-accessors are typically used by the "requires" side as a convenient way to "get" remote data. Since the provider isn't actually retrieving the 4 items listed here, they can be removed:

http://bazaar.launchpad.net/~ibmcharmers/interface-ibm-mq/trunk/view/head:/provides.py?start_revid=1#L10

Thanks for the work on this interface thus far - let me know if you have any questions/concerns about this review.

[Anita Nayak (anitanayak)]

Updated the interface code as per the review comment and checked-in to launch-pad.

Thanks for reviewing.