new charm:sosreport_charm

[Louis Bouchard]

Here is the charm layer for sosreport based on the basic layer :

https://github.com/karibou/sosreport_charm.git

[Jorge Niedbalski (niedbalski)]

Hello Louis,

Thank you for submitting this new charm.

I have a few observations in regards to your proposal.

1) Please make sure to identify the series supported by your charm, by using the following metadata directive:

    series:
       - trusty
       - xenial

Ofc, make sure your charm deploys correctly on all the mentioned series and your amulet
tests pass on all of them.

2) Please, fix the following lint issues:

reactive/sosreport.py:1:1: F401 'os' imported but unused
reactive/sosreport.py:2:1: F401 'split' imported but unused
reactive/sosreport.py:31:5: F841 local variable 'cfg' is assigned to but never used
reactive/sosreport.py:51:1: E302 expected 2 blank lines, found 1
reactive/sosreport.py:53:5: F841 local variable 'cfg' is assigned to but never used
Makefile:17: recipe for target 'lint' failed

3) In regards to unit tests, make sure to have a good code coverage of actions/cleanup.py, in particular try to give coverage to the lines 37-41:

actions.cleanup 37 7 81% 37-41, 45, 48

4) Usability issue, I think it would be better to merge the minfree and mingig options
into a single option.

<niedbalski> "minfree":
<niedbalski> "type": "integer"
<niedbalski> "description": "Minimum percent of free diskspace to run sosreport"
<niedbalski> "mingig":
<niedbalski> "type": "integer"
<niedbalski> "description": "Minimum number of Gb of free diskspace to run sosreport"

Please comment on this bug once you have this sorted out or you have any question,
so I can continue reviewing your submission.

[Louis Bouchard (louis)]

Hi,

Thanks for the review.

I just pushed new commits to the git repository. Here is summary of the changes :

- Added trusty to the default series
- Added indication to the Xenial Amulet test to the fact that it will fail until GH issue 155 for the amulet script is resolved (https://github.com/juju/amulet/issues/155)
- Improved test coverage
- Cleaned up Lint errors
- Merged minfree and mingig into one single parameter

Hope that everything is now good to go.