Reactive Kibana Charmstore Submission

[james beedy]

Reactive re-write of Kibana with added support for Xenial.

Tests, icon.svg, and dashboads were pulled forward from cs:trusty/kibana.

https://code.launchpad.net/~jamesbeedy/charms/xenial/kibana/trunk

[james beedy (jamesbeedy)]

layer-repo: https://github.com/jamesbeedy/layer-kibana.git

[Pen Gale (pengale)]

Hi James,

Thank you for your work on this charm.

When I run the tests via bundletester, I run into the following errors. (I'm using juju2.0, beta 8, deploying locally to LXD containers)

1) Linter fails due to a missing dependency for flake8.
2) 10-deploy.py fails with the following error:

======================================================================
ERROR: setUpClass (__main__.TestDeployment)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/bundletester-A48HGx/kibana/tests/10-deploy.py", line 22, in setUpClass
    cls.deployment.relate('kibana:rest', 'elasticsearch:client')
  File "/home/petevg/.local/lib/python3.5/site-packages/amulet/deployer.py", line 404, in relate
    raise ValueError('%s does not exist for %s' % (rel, srv))
ValueError: rest does not exist for kibana

----------------------------------------------------------------------

I see that the files "10-deploy" and "10-deploy.py" both exist. Are both legitimate tests that need to be run, or is one a holdover from the old charm?

If you have any trouble reproducing the errors, please feel free to ping me, either here, or on freenode#juju (my handle there is "petevg")

[james beedy (jamesbeedy)]

@petevg, I have fixed the errors you pointed out, thanks for that! Hopefully the tests will pass now in the automated testing. How might I kick off another round of tests?

Thanks

[Matt Bruzek (mbruzek)]

@jamesbeedy the automated testing tool called bundletester and you can run it yourself. While we do have a github repository the recommended way to install it is `pip install -U bundletester` (do this in a virtual environment if you wish). Change directory to the base of the charm and run `bundletester -F -l DEBUG -v` that will deploy the charm, run the tests and tear down the charm using your current juju environment.

[james beedy (jamesbeedy)]

@mbruzek, thanks - Don't know how I got this far w/out it.

[james beedy (jamesbeedy)]

@mbruzek, yea ... ultimate fail for bundletester :-(

Bundletester doesn't seem compat with juju-2.0 yet.... I would have to stand up a 1.x env to use it somewhere arrrg.

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4806/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5008/