review ubuntu-repository-cache charm now with multiseries support

Bug #1600243 reported by Robert C Jennings on 2016-07-08
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Charms Collection
Undecided
Unassigned

Bug Description

The ubuntu-repository-charm has been updated to support trusty and xenial. I would request a review of the top 2 commits which update the maintainers field and add the list of supported series. The work to actually get things working for Xenial was already done by axino and merged into the trusty-specific charm. Thanks

Robert C Jennings (rcj) wrote :

Note that the linked branch is named as being the 'trusty' branch because that exists in the charms project. It would move as a result of this merge.

Stuart Bishop (stub) wrote :

I have reviewed these changes, and they are fine. The charm is ready to be pushed to a new home by the maintainer (Cloud Image Developers <email address hidden>), published to the charm store by the maintainer, and promulgated by the Juju ecosystem team.

Matt Bruzek (mbruzek) wrote :

I don't see the changes. Is there a merge proposal somewhere?

Robert C Jennings (rcj) wrote :

mbruzek, there isn't an MP as this won't be targeted against the current charm which is @ charms/trusty/ubuntu-repository-cache, it will need to be pushed as new to charms/ubuntu-repository-cache. So I don't know how you want to review this. I could open an MP against the series-specific branch so you can review the top two patches in my tree.

Marco Ceppi (marcoceppi) on 2016-07-27
Changed in charms:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers