New charm - IBM Spectrum Symphony Node for review

[Prabakaran]

Hello Team,

Here is a new charm for IBM Spectrum Symphony Node for review.

To test this charm, a license to IBM Spectrum Symphony is required.

To test the IBM Spectrum Symphony Node, we need Symphony Storage charm and Symphony Master charm as well. As per the design changes, the Spectrum Symphony charm has been split into three charms:

IBM Spectrum Symphony Storage
IBM Spectrum Symphony Master
IBM Spectrum Symphony Node.

We need all three charms to be deployed to have a functional Symphony Cluster.

And, its source code can be found in the below repository

Repo : https://code.launchpad.net/~ibmcharmers/ibmlayers/layer-ibm-spectrum-symphony-node

The charm has been pushed into charm store as well

branch : cs:~ibmcharmers/ibm-spectrum-symphony-node-0

Thanks

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4121/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4354/

[Konstantinos Tsakalozos (kos.tsakalozos)]

Hi Prabakaran,

Thank you for the work you put on this charm. There are some thinks that need your attention.

- After building your charm you can go to the output directory and see the lint errors (make lint). Most of them are very easy to fix. http://pastebin.com/NZk4KBEz
- Please make the 10-deploy.py executable.
- Please review the 10-deploy.py as there are syntactic errors http://pastebin.com/sWBcyRGC
- Your tests are using charms that are not promulgated yet. This blocks the validation of the current charm. The reason is that the not promulgated charms may change without notice rendering the current charm unusable. For example, in your tests you are trying to use a relation endpoint that does not exist on the ibm-spectrum-symphony-storage. http://pastebin.com/zhFh4XSn . If you need to test the current charm in the context of a more complex deployment (master+node+storage) you should create a bundle with all of the charms and have tests checking the functionality of the cluster as a whole. You can submit the entire bungle for review.
- In your tests I see you deploy all charms master+node+storage and add the relations to the storage. Then you wait for 100 seconds before adding the relation to the master. This implies that there is a synchronisation issue that affects the service orchestration. Instead of expecting your users to wait for a service to come online the interface with the master should mark the availability of services on either end.

Thank you for your time and effort.

Konstantinos