New IBM NFSStorage interface

[shilpa]

Hi!

Here is a new interface for NFSStorage which can be used by IBM Platform Products like Platform LSF and Platform Symphony for review.

Here is the link for the interface:
https://code.launchpad.net/~ibmcharmers/interface-ibm-nfsstorage/trunk

Thanks

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4011/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4298/

[Pen Gale (pengale)]

+1 on this, based on a read-through of the code.

This does need a repo string set in interface.yaml.

I have not done integration testing on this; we'll need to do full integration testing down the line.

[Konstantinos Tsakalozos (kos.tsakalozos)]

Hi shilpa,

Thank your work on this interface.

Just a couple of easy fixes:
- Shouldn't there be some file with the license included in the charm?
- The interface.yaml should have a maintainers entry.

Can you also please, double check that the methods available through the interface are reported on the README.

Thank you again for your time.

Konstantinos

[shilpa (shilkaul)]

Hi,

I have added entry for maintainers and added this in the juju.interfaces.solutions as well.
Changing the status to Fix Committed for further review.

Thanks,
Shilpa

[Kevin W Monroe (kwmonroe)]

Thanks for the updates Shilpa! I'm marking this as 'Fix Released' since it is available on http://interfaces.juju.solutions/.

[Kevin W Monroe (kwmonroe)]

Hi Shilpa - I noted some lint issues after resolving this bug. It is still resolved, but I wanted to make you aware of the following:

Please note that these interface files will be copied into any charm that includes this interface during the 'charm build' process. That means these will need to pass the python lint checker. You can see that the py files had the following issues when running "flake8 *.py":

ubuntu@877b959101c6:~/charms/interfaces/interface-nfsstorage$ flake8 *
provides.py:5:1: F811 redefinition of unused 'hookenv' from line 1
provides.py:5:1: F401 'charmhelpers.core.hookenv' imported but unused
provides.py:25:1: W293 blank line contains whitespace
provides.py:27:5: E303 too many blank lines (2)
provides.py:29:80: E501 line too long (91 > 79 characters)
provides.py:34:1: W293 blank line contains whitespace
provides.py:35:1: W293 blank line contains whitespace
provides.py:36:5: E303 too many blank lines (2)
provides.py:43:1: W293 blank line contains whitespace
provides.py:45:5: E303 too many blank lines (2)
provides.py:48:13: E122 continuation line missing indentation or outdented
provides.py:49:5: E122 continuation line missing indentation or outdented
provides.py:50:1: W293 blank line contains whitespace
provides.py:51:1: W293 blank line contains whitespace
provides.py:52:5: E303 too many blank lines (2)
provides.py:58:1: W293 blank line contains whitespace
provides.py:59:5: E303 too many blank lines (2)
provides.py:65:1: W293 blank line contains whitespace
provides.py:66:1: W293 blank line contains whitespace
provides.py:68:1: W391 blank line at end of file
requires.py:4:1: F401 'charmhelpers.core.hookenv' imported but unused
requires.py:8:1: E302 expected 2 blank lines, found 1
requires.py:10:1: W293 blank line contains whitespace
requires.py:15:1: W293 blank line contains whitespace
requires.py:17:5: E303 too many blank lines (2)
requires.py:22:1: W293 blank line contains whitespace
requires.py:23:1: W293 blank line contains whitespace
requires.py:24:5: E303 too many blank lines (2)
requires.py:26:80: E501 line too long (91 > 79 characters)
requires.py:32:5: E303 too many blank lines (2)
requires.py:35:1: W293 blank line contains whitespace
requires.py:36:5: E303 too many blank lines (2)
requires.py:40:1: W293 blank line contains whitespace
requires.py:40:1: W391 blank line at end of file

These are very simple fixes, so I went ahead and pushed them to the current branch. You can see these changes here:

http://bazaar.launchpad.net/~ibmcharmers/interface-ibm-nfsstorage/trunk/revision/5

They are strictly formatting and whitespace issues -- no logic changes. Again, this is still 'Fixed'; I just wanted to let you know about the lint issues that were present. Thanks again for the work on this interface!