New Charm: pubphoto (trusty)

[José Antonio Rey]

This is a pubphoto revision for trusty. Currently a precise charm exists, but will soon be unmaintained.

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/3956/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/3911/

[Konstantinos Tsakalozos (kos.tsakalozos)]

Hi Jose,

Thank you for your work in maintaining the pubphoto charm. The charm looks fine, tests pass,
and the site is functional. Good work!

There is only a minor issue that you can easily address. Here:
http://bazaar.launchpad.net/~jose/charms/trusty/pubphoto/trunk/view/head:/tests/10-deploy#L24
you should change "cls.deployment.sentry.unit['pubphoto/0']" to "cls.deployment.sentry.unit['pubphoto'][0]"

Also note that the promulgation process has somewhat changed. As described here: https://jujucharms.com/docs/devel/authors-charm-store
you should push the charm you want promulgated into your private namespace in the stable channel.
We will grab it from there and promulgate it as recommended in the Juju store. Please make sure you mention in the ticket the revision you pushed.

We appreciate your commitment and your hard work.

Thank you,
Konstantinos

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4424/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4404/

[Review Queue (review-queue)]

The results (PASS) are in and available here: http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4442/

[Review Queue (review-queue)]

The results (PASS) are in and available here: http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4462/

[Konstantinos Tsakalozos (kos.tsakalozos)]

Hi Jose,

Thank you for your work on this charm.

You have a +1 from me for promulgating the revision 1 of the charms
https://jujucharms.com/u/jose/pubphoto/trusty/1

Cheers,
Konstantinos

[Konstantinos Tsakalozos (kos.tsakalozos)]

Hi Jose,

Sorry for the delay. Just promulgated the charm: https://jujucharms.com//pubphoto/

Cheers,
Konstantinos