new charm proposal diaspora

[Joe Liau]

Original Author: Jason Robinson
Maintained by me.

[Cory Johns (johnsca)]

Joe,

Thank you for your submission to the charm ecosystem! This charm looks great, and I have only a few minor suggestions for improvement.

First, it would be very helpful to use status-set[1] to report blocking conditions, such as missing the required hostname config or missing the relation to postgresql, as well as informing the admin of the progress of deployment or restart. For example, when you detect that the hostname is not set, you can use this to report that information to the admin:

    status-set blocked "Please set the hostname config option"

Second, it would be nice to add an action[2] for upgrade-charm, so that it can be run directly instead of relying on `juju run`.

Last, you note in the README and config.yaml that hostname cannot be changed after deployment. Though we generally frown very much on what we call "immutable config," I understand that this is a limitation from the diaspora* software itself due to the hostname getting persisted in the database. However, there is nothing in the charm code that actually prevents the hostname from being changed after db initialization. Perhaps some checks would be warranted, or at least more explanatory text in the README and config.yaml as to the consequences of changing that value would be useful.

[1]: https://jujucharms.com/docs/stable/reference-hook-tools#status-set
[2]: https://jujucharms.com/docs/stable/authors-charm-actions

[Joe Liau (joe)]

Hi Cory,

Thank you for taking the time to review this charm.
I have made some commits according to your suggestions.

I addressed the final issue by adding more explanatory text for now.

[Cory Johns (johnsca)]

Joe,

Thank you for your work on this! This charm has been promulgated from your namespace, and is now also visible at https://jujucharms.com/diaspora/ and can be deployed with:

    juju deploy cs:trusty/diaspora

Please note that we have a new process for publishing updates to charms. This new process allows you to push to the store immediately, without having to wait for ingestion, as well as hosting the charm using whatever source control software or provider that you wish. If you have not already seen it, I recommend you read the description of the new process here: https://jujucharms.com/docs/devel/authors-charm-store

Because this charm is now promulgated, publishing to the stable channel is currently restricted to ~charmers. You can freely push to the unpublished channel and publish to the development channel, and deploy from either of those channels. If you have a change ready in the development channel that you wish to be published to stable, please request a review by a ~charmer on the Review Queue (this currently requires a MP or Bug on Launchpad, but we are working to streamline that process as well).

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4480/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4460/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4478/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4498/