New Charm: IBM Platform Application Center

[Geetha S]

Hello Team,

Here is a new charm for IBM Platform Application Center for review.

To test this charm, a license to IBM Platform Application Center is required.
You need to get a Platform Application Center license for at least version 9.1.4.1

Repo: https://code.launchpad.net/~ibmcharmers/charms/trusty/ibm-platform-ac/trunk

And, its source code can be found in the below repository

Repo : https://code.launchpad.net/~ibmcharmers/charms/trusty/layer-ibm-platform-ac/trunk

The charm has been pushed into charm store as well
Branch: cs:~ibmcharmers/trusty/ibm-platform-ac-3

Thanks

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1450/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/1435/

[Pen Gale (pengale)]

Hi,

Thank you for all the work on this charm.

During my review, I found a few issues:

1) It appears that the terms need to be cleaned up to remove a default value, as deploy prompts me to agree to a "lorem-ipsum" term:

`ERROR Declined: please agree to the following terms ibm-platform-ac/1 lorem-ipsum/1. Try: "juju agree ibm-platform-ac/1 lorem-ipsum/1"`

2) The term may be missing. When I agree to the terms, I get the following error:

`ERROR failed to retrieve terms: failed to get unsigned terms: 404 Not Found: {"code":"not found","error":"term ibm-platform-ac/1 not found","message":"term ibm-pl
atform-ac/1 not found"}`

Together, these issues mean that I haven't been able to test the charm.

I did read the code, and it overall looked good. I would suggest not doing "chmod 777" on the packages; 755 (or even something more restrictive on reads and writes for "group" and "all") should be sufficient. There is also a typo in one of the status messages: "Platfrom" should be spelled "Platform". Both of these are minor, non blocking issues.