New Charm Submission for mysqltest

[Michael Reed]

The purpose of this charm it to create simple functional tests of mysql.

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-hp/1085/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/1376/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1366/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-azure/1149/

[Cory Johns (johnsca)]

Michael,

Thank you for your submission!

As you can see above, the tests are failing in the CI, and they failed for me as well. This seems to be due to the bundle file that the test uses having local paths for the charms that are specific to your system. I would recommend changing the bundle to deploy the charms from the charm store using the cs: prefix. The mysqltest would need to be deployed from your namespace at first, of course.

I also noticed that the formatting of the README is a bit hard to read on https://jujucharms.com/u/mreed8855/mysqltest/ and it would be good to convert that to Markdown and add some formatting.

Within the charm itself, I was a little confused as to why the benchmarks were being set up and run as Upstart jobs? Surely, they don't need managed as system services or run if the instance is restarted? Also, as Upstart jobs, it seems that they would be run out of band and that you wouldn't capture the timing information that would be useful for these as benchmarks.

I also noticed that you have both actions and a config option as methods for triggering the tests / benchmarks. I would suggest that this seems like a natural fit for actions and a bit awkward to use via the config option. Perhaps the latter could be removed in favor of the former? In the actions, the parameters seem to be unused, so they should probably be removed to keep the interface clean.

[Launchpad Janitor (janitor)]

[Expired for Juju Charms Collection because there has been no activity for 60 days.]

[Michael Reed (mreed8855)]

 I have pushed the fixes up to the branch

[Michael Reed (mreed8855)]

I added additional changes to avoid bundletester failures.

[Cory Johns (johnsca)]

With the changes, the tests pass for me and it all looks good but for two minor suggestions:

* Remove the unused params from actions.yaml (file can contain just this: http://pastebin.ubuntu.com/15096777/)

* Add a blank line just before the first list in the README to fix the formatting

Other than those, which aren't really blocking issues, this seems good for my +1

[Michael Reed (mreed8855)]

I just updated the following:

Removed the unused parameters
Added a blank line to the README.md file

[Cory Johns (johnsca)]

MIchael,

Thanks for the submission and dedication to Juju charms.  This charm is now promulgated!

Within about an hour, the charm will be available at https://jujucharms.com/mysqltest/ and can be deployed with:

    juju deploy cs:trusty/mysqltest

The promoted charm project can be found in Launchpad at: https://launchpad.net/charms/+source/mysqltest

You can start monitoring for bugs at: https://bugs.launchpad.net/charms/trusty/+source/mysqltest

Congratulations on making it into the charm store!

Thanks again!