New Charm: ETCD

[Charles Butler]

Incoming charm for ETCD

[Charles Butler (lazypower)]

When reviewing, there are tests for the proxy relation that are being maintained by the Project Calico folks as they have a direct dependency on this relation

https://github.com/chuckbutler/etcd-proxy-mock-charm/blob/master/tests/10-verify-etcd-proxy

More information about this test, why it lives here, and why it came to be can be found here:
https://github.com/whitmo/etcd-charm/pull/10

[amir sanjar (asanjar)]

Greetings, Chuck. Thank you for this high-quality charm submission, as usual.
Initial Charm review check-list:
1) icon - acceptable
2) charm proof - passed
3) README.md - well organized and informative. Minor issues:
     line 22 : update when move to charmstore
     line 42-43 : Example and format of "cluster-string" would be beneficial to help user parse the data.
4) bundletester : fails http://paste.ubuntu.com/11888125/

[Matt Bruzek (mbruzek)]

Hello Charles,

Thanks for all the work on this charm. The charm seems to be well formed, I see no messages when running charm proof. The python code passes pep8 which follows best practices and looks easy to follow.

I manually deployed the charm on Google Compute Engine (GCE) and scaled it up to 3 nodes successfully. I also ran the tests using bundletester on Amazon Web Services (AWS) and they all passed!
DEBUG:runner:Ran 2 tests in 696.213s
DEBUG:runner:
DEBUG:runner:OK
DEBUG:runner:Exit Code: 0
    10-deploy PASS
DEBUG:bundletester.utils:Updating JUJU_ENV: "amazon" -> ""

PASS: 3 Total: 3 (709.004069 sec)

I updated the README line 22 from the previous review comment. But I will write a bug against the charm to update the README with an example "cluster-string" as that is not a blocker for me.

Thanks again for all the work here. I pushed this to the recommended section of the charm store. Congratulations on a new charm in the store!