Thank you for the submission of this IBM WebSphere eXtreme Scale charm. Here are my review comments: # charm proof The charm proof tool and it reported that there are no relations for this charm. $ charm proof I: all charms should provide at least one thing I would have expected that the ibmwxs charm to have a peer relation. Meaning if you deploy 2 ibmwxs charms they can relate to each other and form a larger data grid or take advantage of having many of these charms deployed in the cloud. As the subject matter expert you know how to use IBM WebSphere eXtereme Scale and how it works. There has to be other applications that can use the Juju relation to this charm. # README.md There are a number of issues with the readme. I use a markdown cheat sheet when writing: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet Things to note are that the return characters are not translated to HTML, so you have to use two spaces after a sentence to insert a line return or the statement “Deploy charms as below: juju deploy ibmwxs” appear on the same line when converted to HTML. There is a markdown format error for the accept-ibm-wxs-license configuration option. Removing the space before the name seemed to fix the problem. The juju set commands do not show up as a code block. To make a code block you either needs four spaces or surround the code in three back ticks (```). Normalize the use of product names such as WebSphere and Ubuntu (search and replace the other cases of the words). Since this charm has no relations the readme should instruct users how to use the software or what you can do with the charm after it is installed. # icon.svg The icon does not have multiple layers. It looks to be a flat image. The icon instructions indicate that the icon must be on the pictogram layer: https://jujucharms.com/docs/devel/authors-charm-icon We don't normally want letters in the icon because they are hard to read at small scale. If that is the only logo for this product the letters are fine. Where does the 6 come from? The version I downloaded was 8.6. Please take another look at the icon and paste the image on the Pictogram layer of the default icon. # Deploy This charm is still very hard to deploy. The instructions are very minimal on setting up the apache server and error prone for users. Please add as much detail as you can to this section. Including how many files a user needs to host and what example file names would be, so they know if it is right or wrong. I was able to set up apache to host these files, but I got several things wrong along the way and would appreciate more information here. # config-changed After hosting the files correctly the config-changed hook failed in error. According to the config.yaml specifying the file names was optional so I didn't specify the file names. Here is how I deployed the charm: $ cat ~/Downloads/ibmwxs_config.yaml ibmwxs: # The private url of the server that has the IBM WXS files. url: http://192.168.122.117 accept-ibm-wxs-license: True accept-ibm-im-license: True sha_im: f35653e20c7925d43007a1cff83623c979109ac5 sha_base: 801bb88913e90413a271b6102d67276a9129dcf3 sha_fixpack: 6e99ec379ed99521a184fbe0086c9d16055a67db $ juju deploy --repository=../../ local:trusty/ibmwxs $ juju set ibmwxs --config=~/Downloads/ibmwxs_config.yaml In the unit log file: 2015-07-31 18:46:20 INFO juju-log Download and extract IM packages 2015-07-31 18:46:20 INFO config-changed sha1sum: /var/lib/juju/agents/unit-ibmwxs-0/charm/files/archives/IM/: Is a directory 2015-07-31 18:46:20 INFO juju-log IBM WXS: IBM IM package is corrupt. The code appears to do a sha1sum on a potentially empty variable name. Line 154 of hooks/config- changed looks like you should change the variable to cfg_im_pkg_name. Also I was not able to initiate more than one config-changed event with the “juju set” command. I can not tell if that is a hook problem or something in the config-changed code but the config-changed hook should be able to run multiple times when ever “juju set” command is called. I am going to put this bug in “In Progress” where you can fix these problems I have identified. When you are ready for another review please put the status in “Fix Committed” and someone will have a look. If you have any questions please join us in #juju or email the list