PLUMgrid charms bundle review required

[Bilal Baqar]

Review is required for the PLUMgrid charms bundle.
https://code.launchpad.net/~plumgrid-team/charms/bundles/plumgrid-ons/bundle

[amir sanjar (asanjar)]

Thanks for submitting your Plumgrid Bundle, however bundle.yaml didn't load using “juju-quickstart” (old bundle spec), had to use “juju-deployer”.
Test result:
* Test on local failed with error:
    ERROR machine 0 is the state server for a local environment and cannot host units
* Test on AWS failed with error (might be issue with my AWS):
unit: neutron-iovisor/1: machine: 1 agent-state: error details: hook failed: "install" 2015-06-04 10:47:03 Deployment stoppe

[Antonio Rosales (arosales)]

Per https://bugs.launchpad.net/charms/+bug/1459567/comments/3 I am moving the status of this bug into "Incomplete" while the charms are finalized.

-thanks,
Antonio

[Antonio Rosales (arosales)]

As a reminder please move the status of this bug back to "Fix Committed" once a fix is ready and a review is needed.

-thanks,
Antonio

[Bilal Baqar (bbaqar)]

We are adding support for KILO openstack in the charms therefore were going to push a patch after that is done. That patch will also address each of the points raised in the reviews above. ETA is this week.

[Bilal Baqar (bbaqar)]

Hey guys just to get you on the same page as us, let me share our progress.
The reviews pointed out the following problems

1. Charles pointed out that our charms were not in accordance with the juju charms policy. They are basic things like passing charms through charm proof. I have already made those changes and will be pushing them in the next patch.

2. Cory pointed out that our charms were failing on AWS. We had not been able to test our charms on AWS at the time therefore they failing on AWS. We have made the changes required and will the add them in the next patch.

3. James wants us to change the architecture of the charms. Currently our charms are dependent on each other but aren't subordinates therefore we have to ensure that they get deployed on the same node. We have finalized the architecture after discussions with James. Our discussion can be followed on the neutron-iovisor charm bug and also these drawings (https://docs.google.com/drawings/d/1_QVGe-uG-iioqeAtaCfQ6H4E5DAVQYAgD7rLAEkUTnU , https://docs.google.com/drawings/d/1rnsMMt4BaiL1qB2nZHKKYuzrhlhmBw6Iba5CH4OYn5s ). We are currently implementing the proposed changes which will take some time as the changes are significant.

Hopefully we will be able to update the charms in the next week.

[Charles Butler (lazypower)]

Greetings Bilal,

Looking over the bundle, everything deployed green and was ready to go. I'm going to +1 this bundle.

There is a caveate to this however, as the bundle points at /next branches - these are not the recommended stable deployments, so the bundle will need to be updated once those branches have been ported to the ~recommended openstack charms. With that small caveate out of the way, I feel this is ready to be promoted.

Thank you for your patience during the review process.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.