Support for Calico in OpenStack: bird

[Cory Benfield]

Related to bug 1421230[0], this submits the bird charm for recommended charm status. This charm is an integral part of deploying Project Calico[1] to provide your virtual networking with neutron, by deploying bird in the capacity of a BGP route reflector. See the original bug[0] for more information.

[0]: https://bugs.launchpad.net/charms/+bug/1421230
[1]: http://www.projectcalico.org/

[Kevin W Monroe (kwmonroe)]

Looking good Cory, and thanks for splitting these related charms out into separate bugs. It'll leverage the automated charm test infrastructure better. That said, please consider a quick Makefile change:

 test: testdep
  @echo Starting tests...
- @$(PYTHON) nosetests --nologcapture unit_tests
+ @$(PYTHON) /usr/bin/nosetests --nologcapture unit_tests

Lest we hit this during make test:

python: can't open file 'nosetests': [Errno 2] No such file or directory

Deployment and relations worked, and with the above change, unit tests looked good too. Thanks for the submission!

[Cory Benfield (cory-benfield)]

Kevin,

Is that diff backwards? The checked in code already has /usr/bin/nosetests in the Makefile, so I take it you want me to switch that to using just 'nosetests' and let $PATH deal with it?

[Kevin W Monroe (kwmonroe)]

Eegads Cory! Like neutron-calico, I'm sorry I missed the open question from you :( I mentioned this on the calico bug, but please set the bug status back to New or Fix Committed when you need more input. That'll cause it to show up on our queue (http://review.juju.solutions/) and will get eyeballs on it.

Re: comment 2, you are correct in that I fubar'd the diff. It was reversed. But now that we're here, let's fix it even better with a python virtualenv so we don't clutter the world's systems with pesky netaddr and netifaces modules :)

Let me know your thoughts on the attached patch.

[Kevin W Monroe (kwmonroe)]

Cory, I'm setting this bug to "In Progress". Please flip it back to New or Fix Committed once you're ready for another look. Thank you!!

[Cory Benfield (cory-benfield)]

Big fan of the patch! I've applied it and pushed it up, so let's respin this.

[Kevin W Monroe (kwmonroe)]

Note to ~charmers, I think all this needed was a +1 from an openstack-charmer. I've had some side convos with jamespage and can proxy his +1 for bird. Let him or I know if anything else is needed for promulgation.. Thanks!

[Kevin W Monroe (kwmonroe)]

I re-deployed this charm once again, and it still seems fine. +1 for the world staying consistent :)

We wanted to exercise the relation to the neutron-calico charm, but are currently having problems getting that deployed [1]. We’ll hold on this one for now until we can verify the bgp-route-reflector relation. Thanks for your patience here!

[1] https://bugs.launchpad.net/charms/+bug/1421230/comments/18

[Kevin W Monroe (kwmonroe)]

Hey Cory, while we're waiting for the calico verification, I went ahead and added a simple deployment test and blurb about unit testing and verification to the README. I've opened a merge proposal in case you're interested:

https://code.launchpad.net/~kwmonroe/charms/trusty/bird/new-tests/+merge/269413

The deployment test in the ./tests subdir will be picked up by our automated test infrastructure. You can manually execute this with bundletester [1] if you want to see the results in your environment:

./bird/tests $ bundletester -v

Let me know if you have any questions/comments.. Thanks!

[1] - https://github.com/juju-solutions/bundletester

[Marco Ceppi (marcoceppi)]

This seems to be waiting for updates before review. If it's ready for review please move the status from "Incomplete" to either "Fix Committed" or "New". Our review queue will pick this item up again and process it for re-review.

Thanks!

[Matt Dupre (matthew-dupre)]

Hi Marco - thanks for the ping. I've taken over these charms from Cory, but hadn't spotted this one.

It's ready for review, so I'll update the status.

Thanks!

[Cory Johns (johnsca)]

Matt,

There were some minor issues with the test, I think due to the etcd charm changing, which I've addressed in https://code.launchpad.net/~johnsca/charms/trusty/bird/review/+merge/276888

With that change, the test passed for me and it looks like the issue with neutron-calico was sorted. I've a minor README update for that charm, and then I think we can get these both promoted.

[Cory Johns (johnsca)]

Matt,

Ping on this. Do my suggested changes look good to you? If so, please merge them into your branch and then I can finish out this review and get these promoted.

Thanks!

[Matt Dupre (matthew-dupre)]

Hi Cory - thanks for the improvements.

I think everything my end is done on this one: please could you go ahead and promote.

Thanks,
Matt

[Cory Johns (johnsca)]

Matt and Cory,

Thank you for your work on this charm! It has now been promulgated into the recommended namespace of the charm store, and should be available at https://jujucharms.com/bird/ within the hour, at which point it can be deployed with just:

    juju deploy bird

I did have one small additional suggestion, which I did not feel warranted blocking the promulgation. You can find it at https://code.launchpad.net/~johnsca/charms/trusty/bird/lint/+merge/283683 and, if you agree with the change, it can be merged into your development branch for inclusion with future updates to the promulgated charm.

We, the community, very much appreciate the effort you've put in to adding these charms to the ecosystem, and look forward to your continued development and additions.

[Matt Dupre (matthew-dupre)]

Thanks Cory, I've merged your proposed lint fix in. Please feel free to go ahead and promulgate this.