Hi Subbarayudu,

Thanks for all of your work putting this charm together for review. I had the opportunity to review it today and wanted to give you some (non-OpenStack-specific) feedback.

There a few common things that new charm authors (myself included) make, that will cause our automated testing to fail. The good news is that these are relatively easy to fix.

[1] `charm proof` - This tool runs a sort of lint against the charm's structure, including validation of `metadata.yaml` and `config.yaml`.

    W: Maintainer format should be "Name <Email>", not "Subbarayudu"
    I: Categories are being deprecated in favor of tags. Please rename the "categories" field to "tags".
    W: README.md includes line 6 of boilerplate README.ex
    W: config.yaml: option vsc-controller-active does not have the keys: default
    W: config.yaml: option vrs-repository-url does not have the keys: default
    W: config.yaml: option vsc-controller-standby does not have the keys: default
    W: config.yaml: option vrs-config-file does not have the keys: default

I's are informational; they're meant to inform you that something should be changed, but isn't against the current charm store policy, nor is it expected to break the charm.

W's mean that a [2] charm store policy is in violation. These are generally easy to fix.

[1] https://juju.ubuntu.com/docs/tools-charm-tools.html

[2] https://juju.ubuntu.com/docs/authors-charm-policy.html

Secondly, `make lint` runs flake8 against the python hooks. This helps to enforce best practices.

    hooks/hooks.py:5:1: F401 'local_unit' imported but unused
    hooks/hooks.py:22:12: E401 multiple imports on one line
    hooks/hooks.py:33:1: E302 expected 2 blank lines, found 1
    hooks/hooks.py:64:1: E302 expected 2 blank lines, found 1
    hooks/hooks.py:97:5: E265 block comment should start with '# '
    hooks/hooks.py:100:42: E225 missing whitespace around operator
    hooks/hooks.py:101:39: E231 missing whitespace after ','
    hooks/hooks.py:101:59: E231 missing whitespace after ','
    hooks/hooks.py:101:80: E501 line too long (86 > 79 characters)
    hooks/hooks.py:104:43: E225 missing whitespace around operator
    hooks/hooks.py:105:39: E231 missing whitespace after ','
    hooks/hooks.py:105:60: E231 missing whitespace after ','
    hooks/hooks.py:105:80: E501 line too long (88 > 79 characters)
    hooks/hooks.py:106:1: W293 blank line contains whitespace
    hooks/hooks.py:109:1: E302 expected 2 blank lines, found 1
    hooks/hooks.py:115:42: E225 missing whitespace around operator
    hooks/hooks.py:117:5: E265 block comment should start with '# '
    hooks/hooks.py:118:39: E231 missing whitespace after ','
    hooks/hooks.py:118:59: E231 missing whitespace after ','
    hooks/hooks.py:121:1: E302 expected 2 blank lines, found 1
    make: *** [lint] Error 1


Last, I'd love to see some [3] tests that our test environment could run, to stand up and configure the environment and related services, so functional tests could be run against the charm, though I understand their may be challenges with that due to the binary payload.


Thanks again for all of your work so far. If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.
--

[1] https://juju.ubuntu.com/docs/tools-charm-tools.html

[2] https://juju.ubuntu.com/docs/authors-charm-policy.html

[3] https://juju.ubuntu.com/docs/authors-testing.html