Request to review the wildfly-ha-slave charm

[saurabh]

Request to review the wildfly-ha-slave charm

[Review Queue (review-queue)]

The results (PASS) are in and available here: http://reports.vapour.ws/charm-tests/charm-bundle-test-10605-results

[Cory Johns (johnsca)]

Saurabh,

Thank you for creating this excellent charm and for incorporating the suggestions from Tim in the wildfly-ha-master charm.

Everything looks good on this charm, and it passes the test included in the master charm, so it gets my +1.

Once both charms are in the recommended namespace in the store, I would recommend replicating the basic test from the master charm here (with the change to make it reference the master charm from the store), so that future changes to this charm can be validated via the tests.

[Tim Van Steenburgh (tvansteenburgh)]

Hi Saurabh!

I intended to promulgate both wildfly charms the Charm Store today, but I just noticed that the slave charm does not actually have any tests. According to Charm Store policy, all trusty charms *must* have tests.

Please see the tests/ directory in the master charm for a good starting point. Once tests are added, we'll get both charms promulgated!

Thanks again for your work on these charms!

[saurabh (jhasaurabh)]

Hi Tim,

I am not much aware about the tests, can I just place a copy of the tests that are there in the mawildfly-ha-master charm?
As far I can understand those test will work for wildfly-ha-slave as well. Please let me know your thougths on this.

Regards,
Saurabh

[Cory Johns (johnsca)]

Tim,

I mentioned in my comment that the test from the master should be able to be copied directly into the slave if the chicken-and-egg changes I mentioned are resolved during merge.

I'd be happy to work with you to get these in a good state to merge, though I can't merge them myself.

[saurabh (jhasaurabh)]

Hi Tim,

I have added test in this charm now. Please have a look.

Regards,
Saurabh

[Matt Bruzek (mbruzek)]

Moving this bug to Fix Committed as the wildfly-ha-slave is in the recommended section of the charms store.

You can access this charm at: https://code.launchpad.net/~charmers/charms/trusty/wildfly-ha-slave/trunk

You can deploy this charm by typing:

juju deploy cs:trusty/wildfly-ha-slave

Thank you for working with us on the review process and thank you for your contribution!

[saurabh (jhasaurabh)]

Thanks Tim and Mark for the continuous support and guidance.