please recommend bind-resolver charm

[LaMont Jones]

Please recommend our bind-resolver charm.

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10356-results

[Matt Bruzek (mbruzek)]

Hello LaMont and thank you for the submission of the bind-resolver charm.

# Review

## Tests:

This branch is failing the automated testing infrastructure. You can view the results here:
http://reports.vapour.ws/charm-tests/charm-bundle-test-10356-results

Looking at the results it appears the code is failing the `make lint` target and the `make test` targets.

The tests included in this charm do not appear to test the bind-resolver charm at all, but are related to openvpn-server charm. Please change the tests to exercse and test the bind functionality.

It should be noted that the automated test infrastructure runs the `make test` target and runs all executables in the $CHARM_DIR/tests/ directory. It would be good to rework the target to avoid duplication. The “test” target could run the unit tests and the “tests” directory could contain the functional tests.

When I ran the tests in the test directory here were the results:

$ ./01_unittests.test

-------------------------------------------------------------------------------

PASSED
$ ./10_juju_integration.test

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

These do not seem to be very good tests. Tests are a required part charms from trusty moving forward. Please rework these tests to run functional and integration tests. Consider writing an Amulet test for the charm. Check examples in other trusty charms such as the lamp charm.

http://bazaar.launchpad.net/~charmers/charms/precise/lamp/trunk/view/head:/tests/10-deploy-test.py

More information can be found about Amulet here:

https://juju.ubuntu.com/docs/tools-amulet.html

Tests should focus on setting configuration values and making sure they are on the Juju unit in the right configuration files. Tests should also test if relations work.

## metadata.yaml

The metadata.yaml file lists some relations that do not exist, and the hooks directory contains hooks that are not listed in the metadata. These inconsistencies should be cleared up before the charm can be recommended.

## README.md
bind9
The readme file is very minimal and needs more description of what bind is and why a Juju user would want to use this charm. Several other sections are empty and would need to be filled in to be a recommended charm. This mardown is converted to html and displayed on the jujucharms.com web page and this readme needs more information on the configuration options as well.

Please update the README with more information.
https://juju.ubuntu.com/docs/authors-charm-policy.html#readme.md

## icon.svg:

The icon for this charm is the OpenVPN icon. That does not seem right. Is there a bind9 or DNS icon that could be used for this charm? Perhaps the letters “DNS” would work here.

## Deploying

The bind-resolver charm deployed successfully for me on my local environment, but I did not know how to use it because the readme was so light on detail. I understand bind is a DNS technology. How or why would someone use this in a Juju environment?

# Conclusion

Thank you again for the submission of the bind-resolver charm. I can see that this charm would be useful for DNS related services in J...

[Launchpad Janitor (janitor)]

[Expired for Juju Charms Collection because there has been no activity for 60 days.]