please recommend openvpn-p2p charm

Bug #1389826 reported by LaMont Jones on 2014-11-05
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Charms Collection
Undecided
Unassigned

Bug Description

Please recommend our openvpn-p2p charm

Matt Bruzek (mbruzek) wrote :

Thank you for the submission of the openvpn-p2p charm. It would be nice to have OpenVPN charms like this in the recommended section of the charm store to give Juju users more security related options!

# Review

## Tests

This merge is failing the automated testing infrastructure. You can see the results here:
http://reports.vapour.ws/charm-tests/charm-bundle-test-10355-results

The charm proof reports an Error level message that is failing that result:
$ charm proof
I: Categories are being deprecated in favor of tags. Please rename the "categories" field to "tags".
I: relation openvpn-p2p-service has no hooks
E: Unknown relation field in relation openvpn-pki-recipient - (gets)
I: missing recommended hook start
I: missing recommended hook stop

Since this charm has a Makefile the CI tool also runs `make lint` and `make test` both targets fail. These targets must pass before the merge can be accepted.

## metadata.yaml

The `gets` line can be removed that is a very old Juju convention that is no longer supported. This is the reason that charm proof fails with an error. Removing the gets line should be all that is needed here.

## test.py

The test.py file that is referenced from the `make test` target appears to be copied from the postgresql charm and does not deploy openvpn-p2p charm at all. This is not a good test of the openvpn-p2p charm and should be changed to deploy the charm. Consider writing an Amulet test for the charm. Check examples in other trusty charms such as the lamp charm.

http://bazaar.launchpad.net/~charmers/charms/precise/lamp/trunk/view/head:/tests/10-deploy-test.py

More information can be found about Amulet here:

https://juju.ubuntu.com/docs/tools-amulet.html

## README.md

The readme does not give much detail about what the openvpn software is, or what it does. I would also expect to see how to deploy the **openvpn-p2p** charm. The readme appears to be copied from openvpn-server and has several other sections that are empty.

The readme is the place to describe all the configuration options to the user of the charm. I would expect to see a lot more information in the readme before the charm can be promoted to trusty.

Please update the README with more information.
https://juju.ubuntu.com/docs/authors-charm-policy.html#readme.md

## Deploying

I tried deploying the openvpn-p2p charm with no configuration values and got an error in config-changed. The error looks to be related to writing the server certificate. We should be able to deploy the charm without setting any configuration values or document that information in the readme.

# Conclusion

Thanks gain for the charm submission. Setting the bug to `Incomplete` while the things in the review are addressed. Once the issues are addressed please move the bug to “New” or “Fix Committed” and it will be entered back in the review queue.

Feel free to contact me in #juju on Freenode.net if you have questions or need assistance.

Changed in charms:
status: New → Incomplete
Launchpad Janitor (janitor) wrote :

[Expired for Juju Charms Collection because there has been no activity for 60 days.]

Changed in charms:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers