Comment 3 for bug 1366834

Robert, thanks for the great looking charm. Nice use of charm helpers, very clean and well organized w/ good if incomplete docs. All in all well written and useful charm.

Couple, three nits to pick:

Tests: Currently the amulet tests fail when running under bundletester (gives a 404 when the test attempts an http connection). Also consider the amount of python you have in the hooks, I'd like to see a bit more unit coverage.

Docs: "juju add-relationship" needs to be changed to "juju add-relation" (make this mistake all the time myself). Also I noted a number of "hooks" intended for running via juju run such as code to kick off the mirror, but do not see these documented.

so -1 for now, but looks really good. Thanks again Robert!

-w