I've taken the time to re-review the HDP-Hive charm and I have to say this is a great submission. I see no issues with proof, or readme.
As a suggestion it would be great to have the hdp-helpers.py abstracted into a charmhelpers branch proposal so they can be tracked in the contrib portion of charmhelpers, but we've already discussed this. Everything else seems to be in order.
I'm going to promulgate this charm to the bigdata-charmers branch of the charm store.
If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.
Amir,
I've taken the time to re-review the HDP-Hive charm and I have to say this is a great submission. I see no issues with proof, or readme.
As a suggestion it would be great to have the hdp-helpers.py abstracted into a charmhelpers branch proposal so they can be tracked in the contrib portion of charmhelpers, but we've already discussed this. Everything else seems to be in order.
I'm going to promulgate this charm to the bigdata-charmers branch of the charm store.
the bug tracker can be found here: https:/ /bugs.launchpad .net/charms/ trusty/ +source/ hdp-hive
and the charm is deployable via
juju deploy cs:trusty/hdp-hive
If you have any questions/ comments/ concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http:// askubuntu. com.