Add devspace-simulator to the charm store
Bug #1353535 reported by
Jorge Castro
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charms Collection |
Expired
|
Undecided
|
Unassigned |
Changed in charms: | |
status: | New → Incomplete |
To post a comment you must log in.
Hi snilaxan, thanks for this charm submission! I'll be doing a review of your charm and helping you get it ready for the store. Here are the findings of my review:
1. `charm proof` passes, great!
2. charm deploys successfully, great!
3. Beautiful icon!
Needs Work
4. README is sparse and does not explain what URL to access after deploying charm.
5. Files downloaded in install hook need checksum verification.
6. Need -y flag on `apt-get install unzip` in install hook
7. You can remove unused charm-helpers: `rm -rf lib/ scripts/ charm-helpers.yaml`
8. The `port` config option is unused - the port number is hardcoded in the install hook. Remove config.yaml entirely, or ensure that a `juju set devspace-simulator port=<port_num>` will actually change the port. This will require updates to the `config-changed` hook.
9. It appears that the charm is using apache as a reverse proxy. Instead of installing apache, you might consider simply relating an haproxy service to act as the reverse proxy.
Thanks again for your work on this! If you have questions, please feel free to ping me on freenode irc in #juju, or email the list at <email address hidden>!