Hey Benjamin! thanks for the review!!

I'm really busy this days, but I promise to take a look at the problems you
describe.

At first the first error seems wired because we are using this charm
already, but I will deploy another to see what happens.

The tests are really fake, and we where without time to develop tests for
the scenarios the charm already covers.

I guess till next week I will reply with some new status :)

Again, thanks!

Abs,
Sebas.



2014-08-19 1:01 GMT-03:00 Benjamin Saller <email address hidden>:

> Thanks for the continued development of this!
>
> Nice use of ansible roles from the ecosystem.
>
> I'd suggest removing the `deploy` target from the makefile, it adds very
> little and is just another thing to think about when making this cross
> series.
>
> However I was unable to deploy under either precise or trusty. Under
> trusty the package name of a dep must have changed, but under precise
> which is expected to work I got the following:
>
> 2014-08-19 03:37:12 INFO install TASK: [pbuyle.nginx-drupal | Create
> sites-enabled configuration directory] ****
> 2014-08-19 03:37:12 INFO install changed: [localhost]
> 2014-08-19 03:37:12 INFO install
> 2014-08-19 03:37:12 INFO install TASK: [pbuyle.nginx-drupal | Create
> available sites configuration files] ******
> 2014-08-19 03:37:12 INFO install fatal: [localhost] => {'msg':
> "AnsibleUndefinedVariable: One or more undefined variables: 'dict object'
> has no attribute 'limit_conn'", 'failed': True}
> 2014-08-19 03:37:12 INFO install fatal: [localhost] => {'msg': 'One or
> more items failed.', 'failed': True, 'changed': False, 'results': [{'msg':
> "AnsibleUndefinedVariable: One or more undefined variables: 'dict object'
> has no attribute 'limit_conn'", 'failed': True}]}
> 2014-08-19 03:37:12 INFO install
> 2014-08-19 03:37:12 INFO install FATAL: all hosts have already failed --
> aborting
> 2014-08-19 03:37:12 INFO install
> 2014-08-19 03:37:12 INFO install PLAY RECAP
> ********************************************************************
> 2014-08-19 03:37:12 INFO install            to retry, use: --limit
> @/home/ubuntu/site.yaml.retry
> 2014-08-19 03:37:12 INFO install
> 2014-08-19 03:37:12 INFO install localhost                  : ok=30
>  changed=22   unreachable=1    failed=0
>
>
> Additionally I was unable to run the unit tests.
>
> EEE
> ======================================================================
> ERROR: Most of the hooks let ansible do all the work.
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/precise/drupal/unit_tests/test_hooks.py", line 57, in
> test_default_hooks
>     hooks.execute([hook])
> AttributeError: 'module' object has no attribute 'execute'
>
> ======================================================================
> ERROR: test_applies_install_playbook (test_hooks.InstallHookTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/precise/drupal/unit_tests/test_hooks.py", line 37, in
> test_applies_install_playbook
>     hooks.execute(['install'])
> AttributeError: 'module' object has no attribute 'execute'
>
> ======================================================================
> ERROR: test_installs_ansible_support (test_hooks.InstallHookTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/precise/drupal/unit_tests/test_hooks.py", line 30, in
> test_installs_ansible_support
>     hooks.execute(['install'])
> AttributeError: 'module' object has no attribute 'execute'
>
> ----------------------------------------------------------------------
> Ran 3 tests in 0.024s
>
> FAILED (errors=3)
>
>
> ** Changed in: charms
>        Status: Fix Committed => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1315428
>
> Title:
>   Review needed: Drupal Charm
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/charms/+bug/1315428/+subscriptions
>