Create a new Apache Tomcat Juju Charm.
Bug #1295710 reported by
Matt Bruzek
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Juju Charms Collection |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
This bug is going to track the progress of a new Apache Tomcat Juju Charm.
Please let me know if you find any issues or have suggestions for improvements.
Thanks!
Related branches
lp:~mbruzek/charms/precise/tomcat/trunk
- Kevin W Monroe: Approve
- Cory Johns (community): Approve
-
Diff: 96 lines (+18/-14)4 files modifiedhooks/webapp-container-relation-joined (+6/-0)
hooks/webapp-relation-joined (+0/-6)
metadata.yaml (+6/-2)
tests/10-configured-deploy.py (+6/-6)
Revision history for this message
| Charles Butler (lazypower) wrote | #1 |
| Changed in charms: | |
| status: | New → Fix Released |
To post a comment you must log in.
Greetings Matt!
Thank you for the charm submission! I've pulled the charm and I have the following comments:
charm proof returns clean! excellent. Moving on.
I like how you have handled the hooks. It read very cleanly and was easy to follow.
I see tests! I've run the amulet tests and it completed successfully. This is a boon to the charm, and might I add, excellent work!
I've got one knit pick:
In tomcat-common there are several bursts of heredocs. We recommend that you use a templating language such as Cheetah or Jinja2 to build templated files instead of using heredocs. If you're adamant on using heredocs - its good practice to abstract them away into their own include.
Otherwise there is nothing glaringly wrong with this charm. Its of an extremely high quality, and is a welcome addition to the charm store!
Thank you for this submission. Without further delay I'm going to promulgate this charm and it should show up in the store in about 30 minutes. If you have any questions about this review feel free to contact us in #juju on irc.freenode.net or contact the mailing list <email address hidden>
Thanks again, and all the best