Updated ddclient charm submission

[Darryl Weaver]

Here is an updated charm for managing dynamic DNS updates.
Originally taken from David Duffey's excellent original charm and added some improvements.

Juju 1.16 does not allow for service names including dots, so the dotted DNS name notation was unable to work.
The method was changed to set a zone in the configuration and take the service name as the hostname to build a FQDN to register to the dynamic DNS provider.

The hooks were improved so that if configuration options are changed after a relationship has been established it will update the configuration correctly and restart the daemon.

The README file was updated and an icon added.

[Antonio Rosales (arosales)]

Daryl,

Thanks for taking the time to update David's charm and get it ready for review by the ~charmers team for inclusion in the Juju Charm Store. Your contribution to the Juju community are very appreciated.

This post is to let you know the ~charmers team has seen this request and in-depth review will be given shortly.

If you have any question please feel free to ping us in #juju.

-thanks,
Antonio

[Antonio Rosales (arosales)]

Daryl,

# I am providing a initial +1 review. A ~charmer will give a final review and merge this charm for inclusion in the Charm Store if they don't have any additional feedback.

## Review points:
- charm proof ddclient passes
- deployment in EC2 is unsuccessful

I am getting a hook failed error with MySQL charm:
    units:
      wordpress/0:
        agent-state: started
        agent-version: 1.17.6
        machine: "2"
        open-ports:
        - 80/tcp
        public-address: ec2-54-81-138-28.compute-1.amazonaws.com
        subordinates:
          ddclient/0:
            upgrading-from: local:precise/ddclient-17
            agent-state: error
            agent-state-info: 'hook failed: "juju-info-relation-joined"'
            agent-version: 1.17.6
            public-address: ec2-54-81-138-28.compute-1.amazonaws.com

What has been your experience with EC2 and relating to wordpress? I am still investigating, but wanted to let you know of my initial findings.

## Additional Feedback
- It would be really advantageous to have charm tests included in the charm, and there is a proposal out to the community to make this policy. If you can add some functional tests to ensure ddclient is deploying and relating properly that would be very advantageous

## Knit pics
- The Readme could follow the charm tools template (charm create test-charm) to provide additional information. Also markdown renders a little better in the GUI and may be something to consider.

-thanks,
Antonio

[Darryl Weaver (dweaver)]

Antonio,

I've not seen problems with my tests deploying to EC2.
I just tried a deployment using the no-ip.org dynamic DNS update and it all worked fine relating to a wordpress instance for me.
Any idea what failure you saw was?

[Darryl Weaver (dweaver)]

Found the problem now.
So, I have updated the config-changed hook which is linked to juju-info-relation-joined hook.
There was a syntax error that is now corrected and bumped the revision number.

I ran a test on EC2 and it was working correctly for me to deploy with no configuration options.

[Cory Johns (johnsca)]

Darryl,

Thank you for contributions to this charm. With the fix to the config-changed hook, I was able to get this charm to work on EC2.

I agree with Antonio regarding improvements to the README and tests, and would add one small comment: the README currently instructs you to set login, password, and zone before deploying ddclient, but this does not work.

Tests will be required to promote this charm for trusty, but the README improvements aren't blockers for precise, so I give this my +1.

[Charles Butler (lazypower)]

Darryl,

Thank you for the excellent charm submission. I'm +1 on the feedback from the other charmers with regard to the Readme being placed in markdown and following the suggested readme structure.

I've validated the ddclient charm on multiple substrates and services. This works a treat.

You can view the charmstore branch here:
https://code.launchpad.net/~charmers/charms/precise/ddclient/trunk

and incoming bugs against the charm will be under 'bugs' link of the project.

The charm will show up in the charm store within the next 30 minutes.

Thank you again for this submission.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>