Charm Needed: DataStax Opscenter

[Charles Butler]

Opscenter is a cassandra DB monitoring tool

http://www.datastax.com/what-we-offer/products-services/datastax-opscenter

[Marco Ceppi (marcoceppi)]

Hi Chuck, see my review below and thanks for the submission!

# Proof

Nothing major, just a few INFO lines about missing hooks

# Review

- You need to have a fully qualified email address for the maintainer field.

- You're implementing the HTTP interface, but don't have the required hook for opscenter to provide the data for that interface, see: https://github.com/charms/wordpress/blob/master/hooks/website-relation-joined

- The README seems a bit light, but does cover most of the information required

- There has been a lot of work recently to add SSL support in a generic and repeatable way to charms, I'd consider following that convention https://code.launchpad.net/~hazmat/charms/precise/mysql/ssl-everywhere/+merge/207904 has an example

- Icon looks good!

- Tests need to use sudo for operations that require super user permissions

- The 100_deploy test doesn't seem to do much other than validate that the environment comes back with a started state. It'd be preferable to see exercising of relation information and validation of configuration values.

- repo_key URL is susceptible to MITM attacks, since datastax supports SSL, use https to fetch the key. Actually, I see you're also comparing a sha1sum of the key, which is great. Having both SSL and the sum won't hurt though.

- It might be worth generating a self-signed cert during config-changed just to keep going regardless of users input

Thanks for the submission!