Comment 37 for bug 1272083

Hello Xiaoming,

Thanks again for the submission of the HPCC charm. I am sorry for the delay since the last review. Our review queue is quite large and we are getting to each one as fast as we can.

I was able to get the HPCC charm to deploy on a 4GB machine on HP-cloud (OpenStack). I increased the memory for the machine, by calling: “juju set-constraints mem=4GB” after a bootstrap was complete. The HPCC charm deployed and looked to be working properly!

Please note that the hpcc charm is currently available in the charm store under your personal name space at: http://manage.jujucharms.com/~xwang2713/precise/hpcc

Anyone can deploy this charm from the Charm Store using the command:
juju deploy cs:~xwang2713/precise/hpcc

Charms must pass review to get in the official Charm Store, and your submission is very close to passing. My review turned up just a few more things that need addressing.

#Proof

There was one informational message when I ran the “charm proof” command:
I: relation hpcc has no hooks

Informational message are OK, and I see in the past review comments that you wish to have future hpcc relations.

#Review

Now that the hpcc charm deploys I tried to change some configuration options and they did not change on the deployed charm.

The hpcc charm has 14 configuration values, some of which are immutable (can not be changed after the hpcc charm is installed/created). This breaks the Juju user experience. The Juju user expects that when they set a configuration value the charm handles it accordingly. Juju calls the “config-changed” hook when the user changes a value, and some of the configuration options are not processed by the config-changed hook.

Say for example the user wants to change the hpcc-version to a new version of the code after hpcc has already been installed, only the “config-changed” hook is called and hpcc version is not changed, but the user would not know the version has not changed and expect to be using the new version. Another example is the public or private keys, say the user wants to use new keys with the hpcc cluser and calls “juju set hpcc ssh-key-private=<private_key>” after deployment. The keys are only set in the install hook, or the hpcc-cluster-relation-joined hook and would not get updated.

Immutable configuration should only be used to prevent data loss, or in other important cases. I would highly recommend refactoring the code to process all the configuration options in the config-changed hook or in the hpcc-common file that is called from config-changed.

#Minor Issues.

The README.md file references a different version 4.3.0-4 of HPCC than what is in the config.yaml (version 5.0.0-3).

Some of the README formatting looks to be off when I converted markdown to HTML. In the General Usage section “juju status” is not indented properly because there needs to be an additional new line after “run”. The backquotes (`) are not needed when you properly indent the block 4 spaces.

I was not able to access the GUI after running the first two commands in General Usage. Add the command “juju expose” to the first group of commands before giving instruction to use the GUI.

Thanks again for the updates! I have moved this bug to Incomplete as a result of the review. Once you've addressed the issues above either with code changes or comments, and wish to have another review, simply move the bug back to either "New" or "Fix Committed" to have it added back to the review queue.

There is not much left to do, the charm is really looking good. We appreciate your submission so far and look forward to the next round of reviews!

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>