Sorry,   ignore my previous node.
Don't think it will work since install hook can't see juju server ssh-keys
directory.
I am not sure if there is a way to around this.
Basically allow user generate ssh-keys put to hpcc/ssh-kyes directory then
deploy.
It is OK for local repository. Don't know how it works from juju-store


On Wed, Jan 29, 2014 at 9:54 AM, Xiaoming Wang <email address hidden> wrote:

> Hi Charles & Marco,
>
> For ssh key I will create variable of ssh key directory in config.yaml
> If it defined our charm will use it instead of default one shipped with
> our charm.
>
> I hope this will work with charm store as well. If not let me know.
>
> Thanks
>
>
> On Tue, Jan 28, 2014 at 2:35 PM, Charles Butler <
> <email address hidden>> wrote:
>
>> Greetings Xiaoming,
>>
>> First, I want to thank you for the excellent work on this charm. I'm
>> really excited to be reviewing a charm that has integrated support for
>> multiple host operating systems, and installation paths. There were some
>> rough corners that I've identified in my cursory review of the charm,
>> the notes are as follows:
>>
>> `Charm Proof`
>>
>> When executing 'charm proof' it returns that hpcc has no hooks. I assume
>> this interface is exposed for peer relationship purposes to get the
>> public-ip of its peer?
>>
>> Readme:
>>
>> Your  work in the Readme is excellent. I went through the example
>> deployment and found everything was very straight forward. I've tested
>> this with both the Local Provider and Amazon EC2 environments, and both
>> completed without an issue.
>>
>> Further down the readme, I was looking for further instruction on the
>> configuration options. These are well documented in the interface thanks
>> to your verbose config.yaml, however its good practice to expand on the
>> configuration detail in the README. It would be a good idea to itemize
>> the list of configuration options, go over in detail what the defaults
>> are providing, and cover any of the specifics of each configuration
>> option.
>>
>> Another item that I missed in the Readme was a callout to the necessity
>> of running a third party script from the CLI to complete the scaling
>> process among peers. I see its documented in config.yaml, but again,
>> providing a thorough overview in the Readme of this process would be
>> preferrable, along with a documented example run so users know what to
>> expect during the execution of this additional script.
>>
>> I pulled a copy of the .deb from your community edition download portal,
>> and hosted it from a S3 bucket and installed from there to test the
>> custom location installation, and it went flawlessly.
>>
>> Nitpicks:
>>
>> Departed relationship hook uses a file in /tmp, which may not exist if
>> the host machine reboots. It may be better practice to cache this
>> information in $CHARM_ROOT, or another location that is not subject to
>> frequent deletions on reboot.
>>
>> The Provided SSH Keys are a potential attack vector, but have been noted
>> in installation script. When preparing for Charm Store review, this will
>> need to be generated on the host, or configured by the user.
>>
>> Resolution:
>>
>> Barring some simple modifications and documentation updates, I feel this
>> charm will be ready for prime time in no time. Thank you again for the
>> work on this charm. I'm going to move the status of this review to
>> 'incomplete' barring the modifications. When you are ready for another
>> review simply place the status of the charm to 'new' or 'needs review'
>> and we will be more than happy to give it another look.
>>
>>
>> ** Changed in: charms
>>        Status: New => Incomplete
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1272083
>>
>> Title:
>>   HPCC Charm initial check-in for review
>>
>> Status in Juju Charms:
>>   Incomplete
>>
>> Bug description:
>>   A new Juju Charm - hpcc is submitted for review.
>>   The README.md has the information for how to use the charm.
>>
>>   For charm code:
>>     config.yaml:   there are parameters to control which HPCCSystems use
>> can install. There are other parameters for how to configure
>>                                the cluster.
>>     bin/  : There are some help scripts we put here mainly for
>> re-configure HPCC cluster. Default configuration may not meet user need.
>>                 We understand it probably not recommend way for juju
>> charm. But we want to give user convenient  way to access the tools.
>>                 We are open for discuss these during the review process.
>>     icon.svg: We haven't gotten which icon we should use. It is in our
>> internal process.
>>
>>     Currently HPCC charm doesn't have related to any other charms.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/charms/+bug/1272083/+subscriptions
>>
>
>