new charm docker
Bug #1226273 reported by
Matthew Williams
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charms Collection |
Expired
|
Undecided
|
Unassigned |
Bug Description
First attempt at a simple charm to install docker and start the daemon.
It's quite basic at the moment, but I thought by getting something into the store it would hopefully inspire someone who knows more about docker to run with the idea
Related branches
description: | updated |
To post a comment you must log in.
Hi Matthew, thanks for your submission. Sorry it's taken so long to get around to reviewing this - future reviews should be a little quicker.
There's a few things wrong with the charm off the bat:
E: Metadata is missing categories.
W: No icon.svg file.
E: no copyright file
W: all charms should provide at least one thing
W: missing recommended hook stop
The first three are blockers to for this charm landing in the charm store. The fourth is strongly recommended, but given the charm I can see what it doesn't. Lastly, a stop hook would be something to consider if possible.
As for the charm itself, I'm not sure how this charm fits in the with the charm ecosystem. Given there are no relations it seems like an over-glorified ssh abstraction for docker. I can see this being used as a method of driving a machine setup, say if there was a service that had a docker file already, this could be used in place of having traditional machine setup via hooks (much like how the rails charm uses chef to set up the box).
That's something to consider with regards to docker and juju.