Comment 1 for bug 1199052

Revision history for this message
Mark Mims (mark-mims) wrote :

Hi Jose,

This looks great!

Here're a couple of things in the first review pass...

- this looks like it's using it's own installed transport agent (postfix)... instead of using a relation with another transport agent. We should implement the relation logic to use an external mta... then add the option for the user to use a local mta or to _relate_ to an external mta via hooks like mta-relation-joined and mta-relation-changed.

- This service should really implement a 'website' relation that implements the 'http' interface. That way it could be related to a web proxy and/or other web-consuming services.

- charm proof gripes about some things:
{{{
hawk:~/reviews $ charm proof mailman
E: Unknown root metadata field (category)
W: Metadata is missing categories.
I: relation mailinglist has no hooks
I: relation mta has no hooks
}}}

- not sure what a 'mailinglist' interface would look like? What would go in the hooks for this kind of relation? What sort of services would consume that? drupal, wordpress, or something like that?

Awesome progress, let's see which direction you would like to go.