swift-proxy fails to install when source is a ppa

Bug #1124471 reported by Andreas Hasenack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Charms Collection
Fix Released
Undecided
Unassigned

Bug Description

lp:~charmers/charms/precise/swift-proxy/trunk/

The install hook has this:
def install():
    src = utils.config_get('openstack-origin')
    if src != 'distro':
        openstack.configure_installation_source(src)
    check_call(['apt-get', 'update'])
    rel = openstack.get_os_codename_install_source(src)

    pkgs = swift.determine_packages(rel)
    utils.install(*pkgs)

get_os_codename_install_source() doesn't handle a src that is a ppa, like this: ""ppa:ubuntu-cloud-archive/grizzly-staging". It will just fall off the end and return None. Then pkgs becomes None too, and everything fails:

2013-02-13 13:46:12,463: hook.output@INFO: TypeError
2013-02-13 13:46:12,463: hook.output@INFO: :
2013-02-13 13:46:12,463: hook.output@INFO: install() argument after * must be a sequence, not NoneType

Tags: landscape

Related branches

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This was merged in revision 37 of swift-proxy.

Changed in charms:
status: New → Fix Committed
Changed in charms:
status: Fix Committed → Fix Released
tags: added: landscape
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.