New Charm bonnie++

[Michael Reed]

This is my first charm that I am proposing for the charm store

https://code.launchpad.net/~mreed8855/charms/precise/bonnie/trunk

This charm allow a user to run bonnie++ with different levels of stress.

[Juan L. Negron (negronjl)]

Reviewing this now.

-Juan

[Juan L. Negron (negronjl)]

Hi Michael:

Thank you for the charm. Here is some feedback on it:

charm proof returns:
W: all charms should provide at least one thing

One of the reasons to use juju is it's ability to relate services to one another. Lacking an interface prevents this charm from relating to any other charm.

Having read a bit about your charm, I wonder if this would be better as a subordinate charm.
Deploying this as a main charm ( for example in EC2/OpenStack ) would not be very helpful as the "hard drive" could be from a diff. ephemeral drive every time you instantiate a node.

I can see the value of it in MaaS when testing dedicated drives, etc. but, at the moment, I don't think it should be included in the charm store.

I am going to leave it here marked as "New" and will request some of my fellow charmers to review it as well and provide feedback.

[Jim Baker (jimbaker)]

Agreed with Juan re making this a subordinate. Seems to me this would work well as:

$ juju deploy ubuntu
$ juju deploy bonnie
$ juju deploy add-relation bonnie ubuntu

for basic testing, but it could also work with other deployments, such as with ceph.

Also some other issues:

1. Does the bonnie service only support the configuration option at deploy? Or it would be reasonable to change at a later point, with juju set bonnie testtype=full

2. I would expect install to only install the bonnie service. Use start/stop to start and stop respectively. (Stop only works on the golang port, but that's forthcoming.)

3. Needs more detailed README on how to actually get the test data. A good way to do this would be to show viewing or copying over the bonnie results with juju ssh. A sample would be nice too. In general, it's hard to go wrong with making a more detailed README.

With these fixes, I could see this a worthwhile addition to the charm store. Thanks for your submission!

[Juan L. Negron (negronjl)]

Marking as Incomplete based on my review as well as Jim's.

Thanks,

Juan

[Michael Reed (mreed8855)]

Thanks for your comments and feedback, I appreciate it, I will incoporate the changes from the feedback , I do need clarity on Jim's second comment

"2.I would expect install to only install the bonnie service. Use start/stop to start and stop respectively. (Stop only works on the golang port, but that's forthcoming.)"

So in the install hook I install bonnie++ and then create a config file for upstart in /etc/init.
In the start hook I start the service created in upstart and in the stop hook I stop the service, so I am a bit confused as to what else needs to be done for that requirement. Can you please clarify?

Thanks,
Michael

[Launchpad Janitor (janitor)]

[Expired for Juju Charms Collection because there has been no activity for 60 days.]

[Mark Mims (mark-mims)]

flipping status to incomplete to get this off the review queue... flip it back to 'fix committed' when ready for another round please.

Thanks!

[Michael Reed (mreed8855)]

https://code.launchpad.net/~mreed8855/charms/precise/bonnie/trunk

I have addressed the following issues in this charm:

*I have added the functionality of changing the configuration option to uses juju set bonnie testtype=< other options >
  with a config-change hook

* I have reorganized the stop, start and install scripts to run the respective functions

*I have added much more detail inside the README file. I have included info on how to find the results and more details on the testcases itself.

What I haven't addressed is the following:

I can see this as a possible subordinate charm for ceph, but I am unclear how running bonnie++ with the ubuntu charm is more useful than just running on the cloud images provided. If I run the bonnie++ charm and can access a system that it is running via juju ssh $number and see the results, how is that different with adding the ubuntu charm.

[Michael Reed (mreed8855)]

I have updated the charm to address all the issues raised in this bug. This charm is now a subordinate charm and I was able to test it with the ubuntu charm as requested in comment #3

$ juju deploy ubuntu
$ juju deploy bonnie
$ juju deploy add-relation bonnie ubuntu

Ignore the final question in comment #8

[Mark Mims (mark-mims)]

Thanks Michael!