cinder-lvm migration documentation - missing target_helper configuration

[Hemanth Nakkina]

tgt package is removed from wallaby release [1] and so tgtadm which is the default target_helper for lvm backend wont work. Attaching a volume with lvm backend fails with default settings from wallaby release.

target_helper need to be set to lioadm. This can be set via charm config option
juju config cinder-lvm config-flags=target_helper=lioadm

Also upgrade from earlier releases to wallaby with cinder lvm backend fails without modifying the above setting.

This requires a mention probably at cinder lvm migration documentation or any better place.

[1] https://git.launchpad.net/~chris.macnaughton/ubuntu/+source/cinder/commit/?id=7a58fa04458232caffb50788938cb6d0b3d06f25
[2] https://docs.openstack.org/project-deploy-guide/charm-deployment-guide/latest/cinder-lvm-migration.html

[Billy Olsen (billy-olsen)]

Adding charm-cinder-lvm as this should be handled in the charm.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-deployment-guide/+/828430

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Luciano Lo Giudice <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-deployment-guide/+/828430
Reason: Will reimplement it in the charm itself.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/828574

[Erlon R. Cruz (sombrafam)]

Added migration steps for charm: https://review.opendev.org/c/openstack/charm-guide/+/855430

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/861377

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/861378

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/861379

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/861307

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/900491

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/900492

[Peter Matulis (petermatulis)]

Removing charm-guide bug task as the issue will be resolved in the software.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/828574
Committed: https://opendev.org/openstack/charm-cinder-lvm/commit/3144ea032b35842db6f62bbb26aef9c68a6226a6
Submitter: "Zuul (22348)"
Branch: master

commit 3144ea032b35842db6f62bbb26aef9c68a6226a6
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Feb 9 12:18:01 2022 -0300

    Fix target_helper config for >= Wallaby

    Starting with the release of Wallaby, the 'tgtadm' package is
    now the default target helper, which doesn't work for cinder-lvm.
    As such, we need to explicitly set the new package to 'lioadm'.

    Closes-Bug: #1949074
    Change-Id: I4d88d1e30d8b2b133bd575a76d0dc5e566415cbc

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/861307
Committed: https://opendev.org/openstack/charm-cinder-lvm/commit/80aa1207356afaa376dcb217dc655ee40d9dfdca
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 80aa1207356afaa376dcb217dc655ee40d9dfdca
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Feb 9 12:18:01 2022 -0300

    Fix target_helper config for >= Wallaby

    Starting with the release of Wallaby, the 'tgtadm' package is
    now the default target helper, which doesn't work for cinder-lvm.
    As such, we need to explicitly set the new package to 'lioadm'.

    Closes-Bug: #1949074
    Change-Id: I4d88d1e30d8b2b133bd575a76d0dc5e566415cbc
    (cherry picked from commit 3144ea032b35842db6f62bbb26aef9c68a6226a6)
    (cherry picked from commit 3b04e42f31a9638858c7f6fa11215090175e4681)
    (cherry picked from commit eb636fa47b276fd2c1d419842ceccf97d272eb76)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/900491
Committed: https://opendev.org/openstack/charm-cinder-lvm/commit/3b04e42f31a9638858c7f6fa11215090175e4681
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 3b04e42f31a9638858c7f6fa11215090175e4681
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Feb 9 12:18:01 2022 -0300

    Fix target_helper config for >= Wallaby

    Starting with the release of Wallaby, the 'tgtadm' package is
    now the default target helper, which doesn't work for cinder-lvm.
    As such, we need to explicitly set the new package to 'lioadm'.

    Closes-Bug: #1949074
    Change-Id: I4d88d1e30d8b2b133bd575a76d0dc5e566415cbc
    (cherry picked from commit 3144ea032b35842db6f62bbb26aef9c68a6226a6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/861379
Committed: https://opendev.org/openstack/charm-cinder-lvm/commit/ea55c071a9cf01c9cf304cf05cc4916379218f9b
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit ea55c071a9cf01c9cf304cf05cc4916379218f9b
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Feb 9 12:18:01 2022 -0300

    Fix target_helper config for >= Wallaby

    Starting with the release of Wallaby, the 'tgtadm' package is
    now the default target helper, which doesn't work for cinder-lvm.
    As such, we need to explicitly set the new package to 'lioadm'.

    (cherry-pick modified to disable py36 unit tests as they are not
    needed at yoga, and break as the psycopg2-binary wheel has
    been removed from PyPi, and the tools to build the wheel are not
    in the repo; it's less work to just fake the result on py36 than
    to support it, and it's less CI time as well).

    Closes-Bug: #1949074
    Change-Id: I4d88d1e30d8b2b133bd575a76d0dc5e566415cbc
    (cherry picked from commit 3144ea032b35842db6f62bbb26aef9c68a6226a6)
    (cherry picked from commit 3b04e42f31a9638858c7f6fa11215090175e4681)
    (cherry picked from commit eb636fa47b276fd2c1d419842ceccf97d272eb76)
    (cherry picked from commit 80aa1207356afaa376dcb217dc655ee40d9dfdca)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/900492
Committed: https://opendev.org/openstack/charm-cinder-lvm/commit/c9a627f278480e90b1f4e741d3df0f3951ae7665
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit c9a627f278480e90b1f4e741d3df0f3951ae7665
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Feb 9 12:18:01 2022 -0300

    Fix target_helper config for >= Wallaby

    Starting with the release of Wallaby, the 'tgtadm' package is
    now the default target helper, which doesn't work for cinder-lvm.
    As such, we need to explicitly set the new package to 'lioadm'.

    Also bumps PyYAML dep to 6.0.1 to fix build error

    Closes-Bug: #1949074
    Change-Id: I4d88d1e30d8b2b133bd575a76d0dc5e566415cbc
    (cherry picked from commit 3144ea032b35842db6f62bbb26aef9c68a6226a6)
    (cherry picked from commit 3b04e42f31a9638858c7f6fa11215090175e4681)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/861378
Committed: https://opendev.org/openstack/charm-cinder-lvm/commit/d8a5ec60142300a3d9cb2568b9d6fdc845d280bc
Submitter: "Zuul (22348)"
Branch: stable/xena

commit d8a5ec60142300a3d9cb2568b9d6fdc845d280bc
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Feb 9 12:18:01 2022 -0300

    Fix target_helper config for >= Wallaby

    Starting with the release of Wallaby, the 'tgtadm' package is
    now the default target helper, which doesn't work for cinder-lvm.
    As such, we need to explicitly set the new package to 'lioadm'.

    (cherry-pick modified to disable py36 unit tests as they are not
    needed at xena, and break as the psycopg2-binary wheel has
    been removed from PyPi, and the tools to build the wheel are not
    in the repo; it's less work to just fake the result on py36 than
    to support it, and it's less CI time as well).

    Closes-Bug: #1949074
    Change-Id: I4d88d1e30d8b2b133bd575a76d0dc5e566415cbc
    (cherry picked from commit 3144ea032b35842db6f62bbb26aef9c68a6226a6)
    (cherry picked from commit 3b04e42f31a9638858c7f6fa11215090175e4681)
    (cherry picked from commit eb636fa47b276fd2c1d419842ceccf97d272eb76)
    (cherry picked from commit 80aa1207356afaa376dcb217dc655ee40d9dfdca)
    (cherry picked from commit 48b0b49647fe467244e03b314b0ee13a09cad891)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-cinder-lvm/+/861377
Committed: https://opendev.org/openstack/charm-cinder-lvm/commit/229184b11cade417660bd51190235368547b328a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 229184b11cade417660bd51190235368547b328a
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Feb 9 12:18:01 2022 -0300

    Fix target_helper config for >= Wallaby

    Starting with the release of Wallaby, the 'tgtadm' package is
    now the default target helper, which doesn't work for cinder-lvm.
    As such, we need to explicitly set the new package to 'lioadm'.

    (cherry-pick modified to disable py36 unit tests as they are not
    needed at wallaby, and break as the psycopg2-binary wheel has
    been removed from PyPi, and the tools to build the wheel are not
    in the repo; it's less work to just fake the result on py36 than
    to support it, and it's less CI time as well).

    Closes-Bug: #1949074
    Change-Id: I4d88d1e30d8b2b133bd575a76d0dc5e566415cbc
    (cherry picked from commit 3144ea032b35842db6f62bbb26aef9c68a6226a6)
    (cherry picked from commit 3b04e42f31a9638858c7f6fa11215090175e4681)
    (cherry picked from commit eb636fa47b276fd2c1d419842ceccf97d272eb76)
    (cherry picked from commit 80aa1207356afaa376dcb217dc655ee40d9dfdca)
    (cherry picked from commit 48b0b49647fe467244e03b314b0ee13a09cad891)
    (cherry picked from commit b098bc73dae08c06ed04b740b9ac9d36522a9b4e)