deprecated call warnings in configure-resources action output

[Nobuto Murata]

Usually those warnings are not harmful, but it's visible to user interactions as follows:

DEPRECATION WARNING: Function maybe_do_policyd_overrides_on_config_changed is being removed : Use maybe_do_policyd_overrides instead

Aug 13 01:47:31 + juju run-action --wait octavia/leader configure-resources
Aug 13 01:49:03 unit-octavia-0:
Aug 13 01:49:03 UnitId: octavia/0
Aug 13 01:49:03 id: "6"
Aug 13 01:49:03 results:
Aug 13 01:49:03 Stderr: |
Aug 13 01:49:03 ovs-vsctl: no row "o-hm0" in table Interface
Aug 13 01:49:03 Synchronizing state of octavia-api.service with SysV service script with /lib/systemd/systemd-sysv-install.
Aug 13 01:49:03 Executing: /lib/systemd/systemd-sysv-install disable octavia-api
Aug 13 01:49:03 Unit /etc/systemd/system/octavia-api.service is masked, ignoring.
Aug 13 01:49:03 Warning: Stopping systemd-networkd.service, but it can still be activated by:
Aug 13 01:49:03 systemd-networkd.socket
Aug 13 01:49:03 Stdout: |
Aug 13 01:49:03 Hit:1 http://security.ubuntu.com/ubuntu focal-security InRelease
Aug 13 01:49:03 Hit:2 http://archive.ubuntu.com/ubuntu focal InRelease
Aug 13 01:49:03 Hit:3 http://archive.ubuntu.com/ubuntu focal-updates InRelease
Aug 13 01:49:03 Hit:4 http://archive.ubuntu.com/ubuntu focal-backports InRelease
Aug 13 01:49:03 Reading package lists...
Aug 13 01:49:03 Adding user systemd-network to group octavia
Aug 13 01:49:03 inactive
Aug 13 01:49:03 octavia-api (enabled by site administrator)
Aug 13 01:49:03 active
Aug 13 01:49:03 active
Aug 13 01:49:03 active
Aug 13 01:49:03 active
Aug 13 01:49:03 DEPRECATION WARNING: Function maybe_do_policyd_overrides_on_config_changed is being removed : Use maybe_do_policyd_overrides instead
Aug 13 01:49:03 status: completed
Aug 13 01:49:03 timing:
Aug 13 01:49:03 completed: 2021-08-13 01:49:02 +0000 UTC
Aug 13 01:49:03 enqueued: 2021-08-13 01:47:34 +0000 UTC
Aug 13 01:49:03 started: 2021-08-13 01:47:34 +0000 UTC

[DUFOUR Olivier (odufourc)]

I've located the origin of the issue. It was slightly more complicated as it doesn't come directly from Octavia's charm but from a call within the module charms_openstack.

There is also another fix ongoing for a deprecated call used in the configure-resources action that would lead to this warning on juju debug-logs whenever an action fails :

2021-11-17 12:52:57 INFO unit.octavia/0.juju-log server.go:327 DEPRECATION WARNING: Function action_fail is being removed : moved to function_fail()

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-octavia/+/818912

[Frode Nordahl (fnordahl)]

Thank you for your work on this, however if we want to remove the specific deprecation warning mentioned in comment #1, the target of the change would be charm-helpers itself.

Unfortunately juju has gone through a actions -> functions and back to -> actions round, but the fact remains that actions are actions, and the deprecation warning that refer to the "function" name should be removed.

0: https://github.com/juju/juju/commit/8e1d9c2ccbac461dffae48b5534514d1c86c20f1
1: https://github.com/juju/charm-helpers/issues/459
2: https://bugs.launchpad.net/charm-helpers/+bug/1926317

[OpenStack Infra (hudson-openstack)]

Change abandoned by "DUFOUR Olivier <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-octavia/+/818912
Reason: Review not compliant to what is announced on LP #1926317

[Aurelien Lourot (aurelien-lourot)]

This seems to be an issue in charms.openstack. Fix: https://review.opendev.org/c/openstack/charms.openstack/+/818914

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/818914
Committed: https://opendev.org/openstack/charms.openstack/commit/6b0c1c7cade7cb36cde6573087b87e60eead2d75
Submitter: "Zuul (22348)"
Branch: master

commit 6b0c1c7cade7cb36cde6573087b87e60eead2d75
Author: Olivier Dufour-Cuvillier <email address hidden>
Date: Tue Nov 23 11:59:36 2021 +0100

    Replace deprecated call from charmhelpers policyd

    The use of function maybe_do_policyd_overrides_on_config_changed
    is deprecated in favor of maybe_do_policyd_overrides.
    This would trigger deprecation warning messages not only in logs
    but also in actions such as seen in Octavia Charm

    The unittest covering the call has also been updated accordingly

    Closes-Bug: #1939840
    Change-Id: Iec91d60727533e6291c3ec20442197ac44f4607c