Source does not trigger an upgrade

[Chris Sanders]

With a deployed bionic-stein bundle, I upgraded the cluster to bionic-train and the ceph-fs charm doesn't appear to trigger any upgrade at all. Mon/Osd upgraded as expected.

The code path in the charm seems to indicate there is no upgrade support at all, or it's in a layer and I just didn't find it. However https://docs.openstack.org/project-deploy-guide/charm-deployment-guide/latest/app-upgrade-openstack.html seems to imply it upgrades normally like the rest of the ceph charms.

Reproduce with:
https://pastebin.ubuntu.com/p/qTYbXkh4gr/

After the deploy run through the upgrade steps from the above guide to get the cluster on 14.x series. Ceph-fs will still be on 13.x

[Alex Kavanagh (ajkavanagh)]

Chris, it does seem that the charm doesn't handle the 'source' config param apart from during the installation. i.e. not on config-changed (afaict). It looks like the charm will need an update.

Notes:

The charm also doesn't use charms.openstack and instead uses layer-apt. We should give serious consideration to switching it over to charms.openstack so we can access all of the default behavour of upgrades, managed upgrades, pause/resume, SSL, space support, etc.

[Jorge Niedbalski (niedbalski)]

+1 experienced the same issue described by csanders. raised for awareness that this might be important/critical for upgrades.

[Frode Nordahl (fnordahl)]

https://review.opendev.org/#/c/734613/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/734613
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-fs/commit/?id=ff7ff857799c960c45336a4ce9f1cff6df356a0c
Submitter: Zuul
Branch: master

commit ff7ff857799c960c45336a4ce9f1cff6df356a0c
Author: Frode Nordahl <email address hidden>
Date: Tue Jun 9 15:42:21 2020 +0200

    Fix Ceph upgrade issue by porting charm to common framework

    Move helpers as-is from reactive handler module to charm class.

    Set default of ``source`` configuration option to 'distro' to be
    in line with other reactive charms and the expectations of the
    ``openstack.utils.get_source_and_pgp_key`` function.

    Unpin flake8.

    Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/313
    Depends-On: I6fbde855ba8f83ef5e265bd5b5dfb0d01eae830b
    Change-Id: I2d8e8b244db935673406d2cce9ef34e7252cb50b
    Closes-Bug: #1879072