charms.reactive changes force rework of defaults implementation

Bug #1707685 reported by Alex Kavanagh on 2017-07-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack AODH Charm
Undecided
Unassigned
OpenStack Barbican Charm
Undecided
Unassigned
OpenStack Designate Charm
Undecided
Unassigned
OpenStack Manila Charm
Undecided
Unassigned
charms.openstack
Critical
Alex Kavanagh

Bug Description

charms.reactive changed due to commit "Allow pluggable alternatives to RelationBase (#111)" (https://github.com/juju-solutions/charms.reactive/commit/95493a4dfe4d25a4d5e87342626ffe456873d360) in that it now only searches 'reactive' and 'hooks' directories, whereas it used to search the whole charm, and allow handlers to be registered from libraries (in the charms.openstack). This no longer works as of 26th June.

This only became apparent when debugging an issue on charm-manila and noticing that, although the handlers were being logged as being called, charms.reactive didn't actually call the handlers.

This means that the defaults that are defined in charms.openstack no longer work. There is a way to make them work, but it means moving the actual default handlers to layer-openstack and layer-openstack-api.

This bug is used to track the behaviour and check that the default handlers work on all the reactive openstack charms.

Changed in charms.openstack:
assignee: nobody → Alex Kavanagh (ajkavanagh)
status: New → In Progress

Reviewed: https://review.openstack.org/489565
Committed: https://git.openstack.org/cgit/openstack/charms.openstack/commit/?id=698337c5eed531d942dc75791248ad8e2ca6bf45
Submitter: Jenkins
Branch: master

commit 698337c5eed531d942dc75791248ad8e2ca6bf45
Author: Alex Kavanagh <email address hidden>
Date: Tue Aug 1 10:11:39 2017 +0100

    Rework the default handlers into layer-openstack-*

    Due to commit 95493a4 in charms.reactive, the default handlers in
    charms.openstack broke. This is because charms.reactive no longer will
    run handlers that are not in the hooks/ or reactive/ directory tree; the
    default handlers in charms.openstack are in the library code, which is
    pip installed into the module packages.

    This patch, and related patches in layer-openstack and
    layer-openstack-api enable the default handlers to function again. Note
    that from a charm author perspective, the API to default handlers is
    identical. This is merely an implementation change.

    Change-Id: I7786a39ab29ab71a4cdb8bd652e8927cbd5fcf5c
    Partial-Bug: #1707685

Alex Kavanagh (ajkavanagh) wrote :

The fix committed in charms.openstack means that no changes are required to any of the charms to use the changed defaults. Therefore, closing all of the bugs as invalid as when they are rebuilt for the next release they will pick up the new versions.

Changed in charms.openstack:
importance: Undecided → Critical
status: In Progress → Fix Committed
Changed in charm-manila:
status: New → Invalid
Changed in charm-designate:
status: New → Invalid
Changed in charm-barbican:
status: New → Invalid
Changed in charm-aodh:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers