the tests for this charm can't be run on Focal
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ceph Monitor Charm |
Fix Released
|
Undecided
|
Chris MacNaughton | ||
Ceph OSD Charm |
Fix Released
|
Undecided
|
Chris MacNaughton | ||
charms.ceph |
Fix Released
|
Undecided
|
Chris MacNaughton |
Bug Description
the unit tests end up doing an import time Version detection which breaks when charmhelpers doesn't understand the running series.
Traceback (most recent call last):
File "/usr/lib/
module = self._get_
File "/usr/lib/
__import_
File "/home/
from ceph_hooks import check_for_upgrade
File "hooks/
import ceph.utils as ceph
File "lib/ceph/
if CompareHostRele
File "hooks/
.format(item, self._list))
KeyError: "Item 'focal' is not in list '('lucid', 'maverick', 'natty', 'oneiric', 'precise', 'quantal', 'raring', 'saucy', 'trusty', 'utopic', 'vivid', 'wily', 'xenial', 'yakkety', 'zesty', 'artful', 'bionic', 'cosmic', 'disco', 'eoan')'"
Changed in charm-ceph-mon: | |
assignee: | nobody → Chris MacNaughton (chris.macnaughton) |
Changed in charm-ceph-osd: | |
assignee: | nobody → Chris MacNaughton (chris.macnaughton) |
Changed in charms.ceph: | |
assignee: | nobody → Chris MacNaughton (chris.macnaughton) |
Changed in charm-ceph-mon: | |
status: | In Progress → Fix Committed |
Changed in charm-ceph-osd: | |
status: | In Progress → Fix Committed |
Changed in charm-ceph-mon: | |
milestone: | none → 20.05 |
Changed in charm-ceph-osd: | |
milestone: | none → 20.05 |
Changed in charm-ceph-mon: | |
status: | Fix Committed → Fix Released |
Changed in charm-ceph-osd: | |
status: | Fix Committed → Fix Released |
Reviewed: https:/ /review. opendev. org/705169 /git.openstack. org/cgit/ openstack/ charms. ceph/commit/ ?id=0434024b2b8 4e7eea6462ad6f8 468827c73defdd
Committed: https:/
Submitter: Zuul
Branch: master
commit 0434024b2b84e7e ea6462ad6f84688 27c73defdd
Author: Chris MacNaughton <email address hidden>
Date: Fri Jan 31 08:38:47 2020 +0100
Fix charms.ceph mocks to not depend on system version
The charms.ceph utils.py library defines a constant based
on the running OS version. This change updates where the
version is read, allowing it to be nicely mocked.
Change-Id: Ibd65526cad0812 f93963bd82619fc d27e055f6f3
Closes-Bug: #1861659