sync-internal-tags needs to run before sync-snaps on release day
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Charmed Kubernetes Testing |
New
|
Undecided
|
Unassigned |
Bug Description
The sync-internal-tags job runs every 12 hours. It ran just before 1.24 GA was released upstream. This means our internal k8s fork did not have the 1.24.0 tag.
Then sync-snaps ran and tried to figure out a non pre-release semver based on the branch name. That failed like this:
-----
15:23:30 20:23:30 | INFO [kube-apiserver] Latest branch version 1.23.6
15:23:30 20:23:30 | INFO [kube-apiserver] > Versions match 1.23.6 == 1.23.6, not building a new snap
15:23:30 20:23:30 | INFO [kube-apiserver] > Checking snaps in version 1.24 for arch amd64
15:23:30 20:23:30 | INFO [kube-apiserver] Found snap version 1.24.0-rc.1 at revision 2756 for 1.24/edge
15:23:32 Traceback (most recent call last):
15:23:32 File "jobs/sync-
15:23:32 cli()
15:23:32 File "/var/lib/
15:23:32 return self.main(*args, **kwargs)
15:23:32 File "/var/lib/
15:23:32 rv = self.invoke(ctx)
15:23:32 File "/var/lib/
15:23:32 return _process_
15:23:32 File "/var/lib/
15:23:32 return ctx.invoke(
15:23:32 File "/var/lib/
15:23:32 return __callback(*args, **kwargs)
15:23:32 File "jobs/sync-
15:23:32 snap_service_
15:23:32 File "/var/lib/
15:23:32 self.snap_
15:23:32 File "/var/lib/
15:23:32 return self._latest_
15:23:32 File "/var/lib/
15:23:32 max_ver = max(map(
15:23:32 ValueError: max() arg is an empty sequence
15:23:32 ERROR: InvocationError for command /var/lib/
-----
We need to either adjust the timing of those 2 jobs, handle errors gracefully, or both.