compose not including lib in/from base layer
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charm Tools |
Fix Committed
|
Undecided
|
Benjamin Saller |
Bug Description
The following line is included in the base layer when composing a charm inhereting from layer: base
import sys
sys.path.
However the lib directory doesn't appear to be constructed properly when composing
ls ../composed/
composer.yaml copyright hooks Makefile metadata.yaml reactive README.md requirements.txt tox.ini
to reproduce generate a composer.yaml with the following contents:
includes: ['layer:basic']
and a metadata.yaml with the following contents:
name: test
summary: test
maintainers:
- test <email address hidden>
description: na
tags:
- layer
subordinate: false
Tested on charm-tools 1.6.1 as well as TRUNK from the charm-tools bzr repository
Possible relevant output:
(.venv)
Inspect test
# layer:basic
# test
# composer
/home/charles/
├─── .composer.manifest
├─── .gitignore
├─── Makefile
├─── README.md
├─── composer.yaml
├─── copyright
└─── hooks
├─── config-changed
├─── install
├─── start
└─── stop
├─── metadata.yaml
└─── reactive
└─── __init__.py
├─── requirements.txt
Related branches
- Marco Ceppi (community): Approve
-
Diff: 167 lines (+26/-19)6 files modifiedcharmtools/compose/__init__.py (+5/-1)
charmtools/compose/inspector.py (+2/-2)
charmtools/compose/tactics.py (+13/-10)
charmtools/utils.py (+2/-2)
setup.py (+2/-2)
tests/test_compose.py (+2/-2)
This has a verified fix in the related branch