conctl changes container manager from docker to ctr when upgrading from 631 to 636

[Seyeong Kim]

Deployed bundle is
https://pastebin.ubuntu.com/p/DTyYp77C9r/

When upgrading calico from 631 to 636 ( I think conctl is involved between them )
, It changes container manager for calico-node from docker to ctr.

I checked below code
https://github.com/charmed-kubernetes/conctl/blob/master/conctl/__init__.py

even if I chose docker as container, it select ctr.
before upgrading, docker container ls had calico-node
but after upgrading, ctr container ls has calico-node ( nothing in docker container ls )

so one of the customer affected by this issue.

Thanks.

[Joseph Borg (joeborg)]

Thanks Seyeong,

It seems the docker.io package is now shipping with `ctr`, which I don't think it used to. This is confusing `conctl`. I can do a hack for a hot fix, but we should figure a better way of detection.

[Joseph Borg (joeborg)]

If it's urgent, in the meantime, you can use the `--force-runtime docker` flag.

[Joseph Borg (joeborg)]

https://github.com/charmed-kubernetes/conctl/pull/5

[Joseph Borg (joeborg)]

Fixed in calico-642

[Joseph Borg (joeborg)]

canal-640

[Joseph Borg (joeborg)]

tigera-secure-ee-61

[Kevin W Monroe (kwmonroe)]

PRs for affected charms:

https://github.com/charmed-kubernetes/layer-canal/pull/38
https://github.com/charmed-kubernetes/layer-calico/pull/41
https://github.com/charmed-kubernetes/layer-tigera-secure-ee/pull/20

[Kevin W Monroe (kwmonroe)]

Fixes cherry-picked to stable:

https://github.com/charmed-kubernetes/layer-canal/commit/d673835729a03ace86c14565e9c3c3a8733be71d
https://github.com/charmed-kubernetes/layer-calico/commit/0733e5f461b6a5726718508a7ec28a3a72c040f8
https://github.com/charmed-kubernetes/layer-tigera-secure-ee/commit/befa12ccdd6d73dd3d2389c81ae7fea7b29f65f9