osci sometimes says gives incorrect PASS messages on reviews
Bug #1843053 reported by
Liam Young
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Charm Test Infra |
Confirmed
|
Low
|
Unassigned | ||
Bug Description
See osci's first comment on https:/
There was a lint error in the PR (which zuul jobs spotted) but osci reported:
charm_build SUCCESS
test_charm_unit SUCCESS
test_charm_lint SUCCESS
osci did, however, correctly nack the change.
Revision history for this message
| Ryan Beisner (1chb1n) wrote | #1 |
Revision history for this message
| Ryan Beisner (1chb1n) wrote | #2 |
| Changed in charm-test-infra: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
To post a comment you must log in.
This is because there are actually two test_charm_lint jobs that run for reactie charms (one for the SRC charm, one for the built charm). There is a javascript screen scraper in the Gerrit web UI, and I believe that is where this bug actually resides. It doesn't handle multiple jobs with the same name.
We could work around that by making sure the two lint jobs have different names for source and build charms, but that seems like the wrong place to attack this.