osci sometimes says gives incorrect PASS messages on reviews

Bug #1843053 reported by Liam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Charm Test Infra
Confirmed
Low
Unassigned

Bug Description

See osci's first comment on https://review.opendev.org/#/c/680676/

There was a lint error in the PR (which zuul jobs spotted) but osci reported:

charm_build SUCCESS
test_charm_unit SUCCESS
test_charm_lint SUCCESS

osci did, however, correctly nack the change.

Revision history for this message
Ryan Beisner (1chb1n) wrote :

This is because there are actually two test_charm_lint jobs that run for reactie charms (one for the SRC charm, one for the built charm). There is a javascript screen scraper in the Gerrit web UI, and I believe that is where this bug actually resides. It doesn't handle multiple jobs with the same name.

We could work around that by making sure the two lint jobs have different names for source and build charms, but that seems like the wrong place to attack this.

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Given the accurate gerrit vote, despite the web UI confusion, triaging low.

Changed in charm-test-infra:
importance: Undecided → Low
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.