Please update telegraf-charm with the latest charm-helpers

[Brian Murray]

I'm seeing the following traceback when trying to deploy telegraf:

2021-09-08 23:36:32 INFO unit.telegraf/7.juju-log server.go:325 Failed executing 'add-apt-repository --yes ppa:telegraf-devs/ppa'. Will retr
y in 10 seconds
2021-09-08 23:36:42 INFO unit.telegraf/7.juju-log server.go:325 Failed executing 'add-apt-repository --yes ppa:telegraf-devs/ppa'. Will retr
y in 10 seconds
2021-09-08 23:36:52 INFO unit.telegraf/7.juju-log server.go:325 Failed executing 'add-apt-repository --yes ppa:telegraf-devs/ppa'. Will retr
y in 10 seconds
2021-09-08 23:37:03 ERROR unit.telegraf/7.juju-log server.go:325 Hook error:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charms/reactive/__init__.py", line 73, in main
    hookenv._run_atstart()
  File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charmhelpers/core/hookenv.py", line 1352, in _run_atstart
    callback(*args, **kwargs)
  File "/var/lib/juju/agents/unit-telegraf-7/charm/reactive/apt.py", line 132, in configure_sources
    fetch.configure_sources(update=False, sources_var='install_sources', keys_var='install_keys')
  File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charmhelpers/fetch/__init__.py", line 149, in configure_sourc
es
    add_source(source, key)
  File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charmhelpers/fetch/ubuntu.py", line 627, in add_source
    fn(*m.groups())
  File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charmhelpers/fetch/ubuntu.py", line 665, in _add_apt_reposito
ry
    cmd_env=env_proxy_settings(['https', 'http']))
  File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charmhelpers/fetch/ubuntu.py", line 781, in _run_with_retries
    result = subprocess.check_call(cmd, env=env, **kwargs)
  File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['add-apt-repository', '--yes', 'ppa:telegraf-devs/ppa']' returned non-zero exit status 1.

2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 Traceback (most recent call last):
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/var/lib/juju/agents/unit-telegraf-7/charm/hooks/install", line 22,
 in <module>
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 main()
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packa
ges/charms/reactive/__init__.py", line 73, in main
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 hookenv._run_atstart()
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packa
ges/charmhelpers/core/hookenv.py", line 1352, in _run_atstart
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 callback(*args, **kwargs)
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/var/lib/juju/agents/unit-telegraf-7/charm/reactive/apt.py", line 1
32, in configure_sources
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 fetch.configure_sources(update=False, sources_var='install_sources', ke
ys_var='install_keys')
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packa
ges/charmhelpers/fetch/__init__.py", line 149, in configure_sources
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 add_source(source, key)
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charmhelpers/fetch/ubuntu.py", line 627, in add_source
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 fn(*m.groups())
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charmhelpers/fetch/ubuntu.py", line 665, in _add_apt_repository
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 cmd_env=env_proxy_settings(['https', 'http']))
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/var/lib/juju/agents/unit-telegraf-7/.venv/lib/python3.6/site-packages/charmhelpers/fetch/ubuntu.py", line 781, in _run_with_retries
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 result = subprocess.check_call(cmd, env=env, **kwargs)
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 raise CalledProcessError(retcode, cmd)
2021-09-08 23:37:03 WARNING unit.telegraf/7.install logger.go:60 subprocess.CalledProcessError: Command '['add-apt-repository', '--yes', 'ppa:telegraf-devs/ppa']' returned non-zero exit status 1.

It's because the http and https proxy are set to squid.internal and no_proxy wasn't being set in the environment. This has been fixed with the following charmhelpers update:

https://github.com/juju/charm-helpers/pull/627

Please update the telegraf charm with this change.

[Drew Freiberger (afreiberger)]

This fix is in ~llama-charmers-next and will be released with the 21.10 cycle.