Telegraf Charm

Add new feature to collect IPMI sensor metric

Bug #1928443 reported by Linda Guo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Telegraf Charm
Fix Released
Medium
Linda Guo
Telegraf Charm 21.07

Bug Description

Add new feature to collect IPMI sensor metric and export the data to prometheus, then add a dashboard in grafana to show the metric.

Related branches

~lihuiguo/charm-telegraf:bug/1928443
Joe Guo (community): Approve
🤖 prod-jenkaas-bootstack (community): Needs Fixing (continuous-integration)
Canonical IS Reviewers: Pending requested
BootStack Reviewers: Pending requested
Diff: 21 lines (+2/-1)
2 files modified
src/templates/base_inputs.conf (+1/-0)
src/templates/sudoers/telegraf_ipmi.tmpl (+1/-1)
~lihuiguo/charm-telegraf:bug-1928443
Joe Guo (community): Approve
🤖 prod-jenkaas-bootstack (community): Needs Fixing (continuous-integration)
Drew Freiberger (community): Needs Fixing
Canonical IS Reviewers: Pending requested
Xav Paice: Pending requested
Haw Loeung: Pending requested
Diff: 162 lines (+57/-3)
7 files modified
src/config.yaml (+7/-0)
src/reactive/telegraf.py (+24/-0)
src/templates/base_inputs.conf (+5/-0)
src/templates/sudoers/telegraf_ipmi.tmpl (+4/-0)
src/tests/functional/tests/base.py (+1/-1)
src/tests/functional/tests/test_telegraf.py (+2/-2)
src/tests/unit/test_telegraf.py (+14/-0)
Linda Guo (lihuiguo)
Changed in charm-telegraf:
status: New → In Progress
assignee: nobody → Linda Guo (lihuiguo)
Linda Guo (lihuiguo)
Changed in charm-telegraf:
importance: Undecided → Medium
Revision history for this message
Laurent Sesquès (sajoupa) wrote :

Are we sure that we want to run as root, commands from a package in universe (ipmitool), potentially on a wide scope ?

Revision history for this message
Linda Guo (lihuiguo) wrote :

Updated the MP to only allow sudo user to collect sensor data ('/usr/bin/ipmitool sensor')

Revision history for this message
James Troup (elmo) wrote : Re: [Bug 1928443] Re: Add new feature to collect IPMI sensor metric

Laurent Sesques <email address hidden> writes:

> Are we sure that we want to run as root, commands from a package in
> universe (ipmitool), potentially on a wide scope ?

As opposed to, say, telegraf itself which isn't even in Ubuntu until
Groovy, and even then is in universe?

If you have specific concerns with ipmitool, happy to discuss them.
But if it's just that it's in universe, that certainly doesn't bother
me.

--
James

Revision history for this message
Laurent Sesquès (sajoupa) wrote :

Well, telegraf doesn't run as root, but fair point.
No concern with ipmitool specifically.
Thanks for the reply, question answered :) (I also had similar feedback when chatting with other SREs)

Revision history for this message
James Troup (elmo) wrote :

Laurent Sesques <email address hidden> writes:

> Well, telegraf doesn't run as root, but fair point.
> No concern with ipmitool specifically.
> Thanks for the reply, question answered :) (I also had similar feedback when chatting with other SREs)

On further consideration, it's not an unreasonable point, in the sense
that Ubuntu Server should come up with an official (supported/in main)
way to interact with IPMI from the CLI. I've added that to the
internal product engineering feedback sheet for the server team to
consider.

--
James

Celia Wang (ziyiwang)
Changed in charm-telegraf:
status: In Progress → Fix Released
milestone: none → 21.07
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.