check_metrics() in functests does not complain if there's no unit

Bug #1913653 reported by Xav Paice
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Telegraf Charm
Won't Fix
Low
Unassigned

Bug Description

Whilst diagnosing an error in functional tests, it was found that in src/tests/functional/tests/base.py, check_metrics() will return without error if there is no unit in principal_units. This was found when the relation between nova-compute and telegraf was missing in the bionic-compute bundle, meaning there were no Telegraf units at all. The test test_01_metrics_available came back as a pass regardless and should have failed because there was no unit at all, let alone available metrics.

Edin S (exsdev)
Changed in charm-telegraf:
importance: Undecided → Low
Revision history for this message
Eric Chen (eric-chen) wrote :

Soon or later, the monitoring system will migrate to COS. Telegraf will be replaced by grafana-agent.
(https://charmhub.io/topics/canonical-observability-stack)
This feature won't be implemented.

Changed in charm-telegraf:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.