ntpmon is outdated

[Junien F]

Hi,

The telegraf charm includes a version of ntpmon that doesn't handle chrony.
The ntp charm version of ntpmon can handle chrony.
They both install ntpmon in the same location (/opt/ntpmon)

If you install both and telegraf install hooks runs after ntp's install hook, then you get an outdated version of ntpmon.

So I think :
1. ntpmon in telegraf should be either updated or discarded
2. telegraf should not install anything in /opt/ntpmon if the directory exists

Thanks

[Zachary Zehring (zzehring)]

What charmstore publisher/revision are you using?

[Jose Guedez (jfguedez)]

Could not reproduce with a deployment of current latest (telegraf-38 and ntp-41). This was using the reported sequence of ntp first, and telegraf second.

After that there was only a single install of ntpmon (by the ntp charm) in /opt/ntpmon-ntp-charm. This location matches the default configuration for configuring the ntpmon in the ntp charm [1].

Telegraf does include the ntpmon layer [2], but does not configure install-dir for ntpmon, which according to the ntpmon layer configuration strings should not install ntpmon at all [3], which seems to match as I didn't see a second installation of ntpmon or it being overwritten during my testing.

In any case, I saw no good reason to include ntpmon as part of telegraf, and after discussing with the team I will create a MP to remove it from telegraf

[1]: https://git.launchpad.net/ntp-charm/tree/layer.yaml#n9
[2]: https://git.launchpad.net/charm-telegraf/tree/src/layer.yaml
[3]: https://git.launchpad.net/ntpmon/tree/layer.yaml#n12