"console=ttyS0,115200 console=tty0" is hard coded and triggers reboot required unnecessarily

Bug #2012581 reported by Nobuto Murata
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
charm-sysconfig
Fix Released
Medium
Ashley James

Bug Description

juju deploy --series jammy sysconfig --config governor=performance
juju add-relation sysconfig "<workload-charm>"

Then, the sysconfig status becomes to:

> update-grub and reboot required Changes in: /etc/default/grub.d/90-sysconfig.cfg, /etc/systemd/system.conf"

This is unexpected because:

1. reboot is not required to apply CPU governor configuration since it can be on the fly.

2. the charm is very opinionated about the GRUB config but it hardcodes tty0 and ttyS0 even when the system already had those values from MAAS kernel parameters.

[/etc/default/grub.d/90-sysconfig.cfg]
GRUB_CMDLINE_LINUX_DEFAULT=""
GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT console=ttyS0,115200 console=tty0"

3. there is nothing changed in /etc/systemd/system.conf out of the box, but it triggers the reboot required flag just because of the timestamp.

Tags: bseng-1027

Related branches

Revision history for this message
Nobuto Murata (nobuto) wrote :

For the record, "clear-notification" action doesn't help in this case. It can delete the message after running the action, but it will come back whenever the next update-status hook is executed.

Revision history for this message
Nobuto Murata (nobuto) wrote :

Basically the same thing as:
https://bugs.launchpad.net/charm-sysconfig/+bug/1854135

But I was requested to file a new one.

Revision history for this message
Nobuto Murata (nobuto) wrote :

Subscribing ~field-high.

Eric Chen (eric-chen)
Changed in charm-sysconfig:
importance: Undecided → Medium
tags: added: bseng-1027
Changed in charm-sysconfig:
status: New → Triaged
Ashley James (dashmage)
Changed in charm-sysconfig:
assignee: nobody → Ashley James (dashmage)
Changed in charm-sysconfig:
status: Triaged → In Progress
Revision history for this message
Ashley James (dashmage) wrote :

"clear-notification" action is now fixed. Relevant code commit here: https://git.launchpad.net/charm-sysconfig/commit/?id=6f88d54f4e62c85ea9fd2595ab45f3f6d3d64db0

Ashley James (dashmage)
Changed in charm-sysconfig:
status: In Progress → Fix Committed
Ashley James (dashmage)
Changed in charm-sysconfig:
milestone: none → 23.07
Ashley James (dashmage)
Changed in charm-sysconfig:
status: Fix Committed → Fix Released
Revision history for this message
Nobuto Murata (nobuto) wrote :

Re-opening as the point 3 is not addressed still:

> 3. there is nothing changed in /etc/systemd/system.conf out of the box, but it triggers the reboot required flag just because of the timestamp.

Changed in charm-sysconfig:
status: Fix Released → Confirmed
Changed in charm-sysconfig:
assignee: Ashley James (dashmage) → nobody
Eric Chen (eric-chen)
Changed in charm-sysconfig:
assignee: nobody → Ashley James (dashmage)
status: Confirmed → Fix Committed
Tianqi Xiao (txiao)
Changed in charm-sysconfig:
milestone: 23.07 → 23.10
Tianqi Xiao (txiao)
Changed in charm-sysconfig:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.