default inode size config is out-of-date

Bug #1879423 reported by James Troup
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Charm Helpers
Fix Committed
Undecided
Unassigned
OpenStack Swift Storage Charm
Fix Committed
Low
Francesco De Simone

Bug Description

The 'xfs-inode-size' in the charm defaults to 512. This contradicts current¹ upstream advice² which is to use the XFS default with any modern kernel.

¹ https://lists.launchpad.net/openstack/msg24784.html
² https://github.com/openstack/swift/blob/master/doc/source/deployment_guide.rst

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Triaged by looking at the code and linked documents. The charm should just accept the filesystem defaults for mkfs.xfs inode sizes.

tags: added: good-first-bug
Changed in charm-swift-storage:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-swift-storage (master)
Changed in charm-swift-storage:
status: Triaged → In Progress
Changed in charm-swift-storage:
assignee: nobody → Francesco De Simone (fdesi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-swift-storage (master)

Reviewed: https://review.opendev.org/c/openstack/charm-swift-storage/+/845629
Committed: https://opendev.org/openstack/charm-swift-storage/commit/98c67e4d92cd4a9dbae16e8f7f6ff1d6e1bd186d
Submitter: "Zuul (22348)"
Branch: master

commit 98c67e4d92cd4a9dbae16e8f7f6ff1d6e1bd186d
Author: Francesco de Simone <email address hidden>
Date: Mon Jun 13 16:21:31 2022 +0000

    Changes to the default inode size

    As per the bug report, the xfs-inode-size default value is in contradiction with the current upstream advice.
    This patch removes the default value and accept the filesystem defaults for mkfs.xfs inode sizes.

    Closes-Bug: #1879423
    Change-Id: I9effc6052524ead9817454912284e3c48ce55901

Changed in charm-swift-storage:
status: In Progress → Fix Committed
Changed in charm-helpers:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.