OpenStack Swift Storage Charm

p35 and py36 tests are failing on a fresh clone from git master branch

Bug #1832829 reported by Tytus Kurek on 2019-06-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Swift Storage Charm	Fix Released	High	Alex Kavanagh	OpenStack Swift Storage Charm 19.07

Bug Description

$ git clone https://github.com/openstack/charm-swift-storage.git
Cloning into 'charm-swift-storage'...
remote: Enumerating objects: 172, done.
remote: Counting objects: 100% (172/172), done.
remote: Compressing objects: 100% (150/150), done.
remote: Total 4805 (delta 82), reused 112 (delta 22), pack-reused 4633
Receiving objects: 100% (4805/4805), 1.42 MiB | 2.16 MiB/s, done.
Resolving deltas: 100% (3004/3004), done.
$ cd charm-swift-storage/
$ tox
pep8 create: /root/TEST/charm-swift-storage/.tox/pep8
pep8 installdeps: -r/root/TEST/charm-swift-storage/requirements.txt, -r/root/TEST/charm-swift-storage/test-requirements.txt
pep8 installed: appdirs==1.4.3,asn1crypto==0.24.0,attrs==19.1.0,Babel==2.7.0,blessings==1.6,certifi==2019.3.9,cffi==1.12.3,chardet==3.0.4,charm-tools==2.6.0,charmhelpers==0.19.13,Cheetah3==3.2.3,cliff==2.15.0,cmd2==0.9.12,colander==1.7.0,colorama==0.4.1,coverage==4.5.3,cryptography==2.7,debtcollector==1.21.0,decorator==4.4.0,dict2colander==0.2,distro==1.4.0,distro-info==0.0.0,dnspython==1.16.0,dogpile.cache==0.7.1,entrypoints==0.3,extras==1.0.0,fixtures==3.0.0,flake8==2.4.1,future==0.17.1,httplib2==0.13.0,idna==2.8,importlib-metadata==0.18,iso8601==0.1.12,Jinja2==2.10.1,jmespath==0.9.4,jsonpatch==1.23,jsonpointer==2.0,jsonschema==2.5.1,jujubundlelib==0.5.6,keyring==19.0.2,keystoneauth1==3.14.0,launchpadlib==1.10.7,lazr.restfulclient==0.14.2,lazr.uri==1.0.3,libcharmstore==0.0.9,linecache2==1.0.0,macaroonbakery==1.2.3,MarkupSafe==1.1.1,mccabe==0.3.1,mock==3.0.5,msgpack==0.6.1,munch==2.3.2,netaddr==0.7.19,netifaces==0.10.9,oauthlib==3.0.1,openstacksdk==0.31.1,os-client-config==1.32.0,os-service-types==1.7.0,osc-lib==1.12.1,oslo.config==6.10.0,oslo.context==2.22.1,oslo.i18n==3.23.1,oslo.log==3.44.0,oslo.serialization==2.29.1,oslo.utils==3.41.0,otherstuf==1.1.0,parse==1.12.0,path.py==12.0.1,pathspec==0.3.4,pbr==1.8.1,pep8==1.7.1,pika==0.13.1,pkg-resources==0.0.0,prettytable==0.7.2,protobuf==3.8.0,psutil==1.2.1,pycparser==2.19,pyflakes==0.8.1,pyinotify==0.9.6,pymacaroons==0.13.0,PyNaCl==1.3.0,pyOpenSSL==19.0.0,pyparsing==2.4.0,pyperclip==1.7.0,pyRFC3339==1.1,python-ceilometerclient==2.9.0,python-cinderclient==4.2.0,python-dateutil==2.8.0,python-glanceclient==2.16.0,python-heatclient==1.17.0,python-keystoneclient==3.19.0,python-mimeparse==1.6.0,python-neutronclient==6.12.0,python-novaclient==14.1.0,python-openstackclient==3.19.0,python-subunit==1.3.0,python-swiftclient==3.7.0,pytz==2019.1,pyudev==0.21.0,PyYAML==3.13,requests==2.22.0,requestsexceptions==1.4.0,rfc3986==1.3.2,ruamel.yaml==0.15.97,SecretStorage==2.3.1,simplejson==3.16.0,six==1.12.0,stestr==2.3.1,stevedore==1.30.1,stuf==0.9.16,Tempita==0.5.2,testresources==2.0.1,testtools==2.3.0,theblues==0.5.1,traceback2==1.4.0,translationstring==1.3,unittest2==1.1.0,urllib3==1.25.3,vergit==1.0.2,virtualenv==16.6.0,voluptuous==0.11.5,wadllib==1.3.3,warlock==1.3.3,wcwidth==0.1.7,wrapt==1.11.1,zipp==0.5.1
pep8 runtests: PYTHONHASHSEED='0'
pep8 runtests: commands[0] | flake8 hooks unit_tests tests actions lib
pep8 runtests: commands[1] | charm-proof
I: metadata name (swift-storage) must match directory name (charm-swift-storage) exactly for local deployment.
I: `display-name` not provided, add for custom naming in the UI
I: config.yaml: option ephemeral-unmount has no default value
I: config.yaml: option harden has no default value
I: config.yaml: option sysctl has no default value
py27 create: /root/TEST/charm-swift-storage/.tox/py27
py27 installed: DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.,pkg-resources==0.0.0
py27 runtests: PYTHONHASHSEED='0'
py27 runtests: commands[0] | /bin/true
py35 create: /root/TEST/charm-swift-storage/.tox/py35
py35 installdeps: -r/root/TEST/charm-swift-storage/requirements.txt, -r/root/TEST/charm-swift-storage/test-requirements.txt
py35 installed: appdirs==1.4.3,asn1crypto==0.24.0,attrs==19.1.0,Babel==2.7.0,blessings==1.6,certifi==2019.3.9,cffi==1.12.3,chardet==3.0.4,charm-tools==2.6.0,charmhelpers==0.19.13,Cheetah3==3.2.3,cliff==2.15.0,cmd2==0.9.12,colander==1.7.0,colorama==0.4.1,coverage==4.5.3,cryptography==2.7,debtcollector==1.21.0,decorator==4.4.0,dict2colander==0.2,distro==1.4.0,distro-info==0.0.0,dnspython==1.16.0,dogpile.cache==0.7.1,entrypoints==0.3,extras==1.0.0,fixtures==3.0.0,flake8==2.4.1,future==0.17.1,httplib2==0.13.0,idna==2.8,importlib-metadata==0.18,iso8601==0.1.12,Jinja2==2.10.1,jmespath==0.9.4,jsonpatch==1.23,jsonpointer==2.0,jsonschema==2.5.1,jujubundlelib==0.5.6,keyring==19.0.2,keystoneauth1==3.14.0,launchpadlib==1.10.7,lazr.restfulclient==0.14.2,lazr.uri==1.0.3,libcharmstore==0.0.9,linecache2==1.0.0,macaroonbakery==1.2.3,MarkupSafe==1.1.1,mccabe==0.3.1,mock==3.0.5,msgpack==0.6.1,munch==2.3.2,netaddr==0.7.19,netifaces==0.10.9,oauthlib==3.0.1,openstacksdk==0.31.1,os-client-config==1.32.0,os-service-types==1.7.0,osc-lib==1.12.1,oslo.config==6.10.0,oslo.context==2.22.1,oslo.i18n==3.23.1,oslo.log==3.44.0,oslo.serialization==2.29.1,oslo.utils==3.41.0,otherstuf==1.1.0,parse==1.12.0,path.py==12.0.1,pathspec==0.3.4,pbr==1.8.1,pep8==1.7.1,pika==0.13.1,pkg-resources==0.0.0,prettytable==0.7.2,protobuf==3.8.0,psutil==1.2.1,pycparser==2.19,pyflakes==0.8.1,pyinotify==0.9.6,pymacaroons==0.13.0,PyNaCl==1.3.0,pyOpenSSL==19.0.0,pyparsing==2.4.0,pyperclip==1.7.0,pyRFC3339==1.1,python-ceilometerclient==2.9.0,python-cinderclient==4.2.0,python-dateutil==2.8.0,python-glanceclient==2.16.0,python-heatclient==1.17.0,python-keystoneclient==3.19.0,python-mimeparse==1.6.0,python-neutronclient==6.12.0,python-novaclient==14.1.0,python-openstackclient==3.19.0,python-subunit==1.3.0,python-swiftclient==3.7.0,pytz==2019.1,pyudev==0.21.0,PyYAML==3.13,requests==2.22.0,requestsexceptions==1.4.0,rfc3986==1.3.2,ruamel.yaml==0.15.97,SecretStorage==2.3.1,simplejson==3.16.0,six==1.12.0,stestr==2.3.1,stevedore==1.30.1,stuf==0.9.16,Tempita==0.5.2,testresources==2.0.1,testtools==2.3.0,theblues==0.5.1,traceback2==1.4.0,translationstring==1.3,unittest2==1.1.0,urllib3==1.25.3,vergit==1.0.2,virtualenv==16.6.0,voluptuous==0.11.5,wadllib==1.3.3,warlock==1.3.3,wcwidth==0.1.7,wrapt==1.11.1,zipp==0.5.1
py35 runtests: PYTHONHASHSEED='0'
py35 runtests: commands[0] | stestr run
{3} unit_tests.test_actions.GetActionParserTestCase.test_definition_from_yaml [0.007697s] ... ok
{0} unit_tests.test_actions.MainTestCase.test_invokes_pause [0.062923s] ... ok
{1} unit_tests.test_actions.PauseTestCase.test_pause_sets_value [0.064547s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_crit_md5sum_mismatch [0.002046s] ... ok
{2} unit_tests.test_actions.MainTestCase.test_failing_action [0.066474s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_failures [0.003035s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_lag [0.003070s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_lag_notworking [0.002860s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_repl_last_timestamp [0.000694s] ... ok
juju-log: INFO: Block device "/tmp/tmp5e8b78w4/null_link" is a symlink to "/dev/null". Using "/dev/null".
{1} unit_tests.test_misc_utils.EnsureBlockDeviceTestCase.test_symlinks_are_resolved [0.010622s] ... ok
{3} unit_tests.test_actions.MainTestCase.test_unknown_action [0.072898s] ... ok
{2} unit_tests.test_actions.ResumeTestCase.test_resume_sets_value [0.078767s] ... ok
{2} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_unknown_valueerror1 [0.001024s] ... ok
{2} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_unknown_valueerror2 [0.002013s] ... ok
{2} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_ok [0.003251s] ... ok
{2} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_unknown_valueerror2 [0.001995s] ... ok
{1} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_rsync_context [0.073033s] ... ok
{2} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_generate_md5 [0.013172s] ... ok
{0} unit_tests.test_actions.PauseTestCase.test_pauses_services [0.114071s] ... ok
{3} unit_tests.test_actions.PauseTestCase.test_bails_out_early_on_error [0.068090s] ... ok
{1} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_swift_storage_server_context [0.089225s] ... ok
{0} unit_tests.test_actions.ResumeTestCase.test_resumes_services [0.083796s] ... ok
{2} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_rsync_enable_rsync [0.089661s] ... ok
{3} unit_tests.test_actions.ResumeTestCase.test_bails_out_early_on_error [0.063071s] ... ok
{3} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_unknown_ioerror [0.001923s] ... ok
{3} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_unknown_urlerror [0.000691s] ... ok
{3} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_warn_failures [0.002751s] ... ok
{2} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_swift_storage_context_with_data [0.066849s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_add_ufw_gre_rule [0.095912s] ... ok
{0} unit_tests.test_actions_openstack_upgrade.TestSwiftStorageUpgradeActions.test_openstack_upgrade_false [0.123027s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_ipv6 [0.179979s] ... ok
{2} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_install_hook [0.144622s] ... ok
juju-log: Upgrading OpenStack release
{0} unit_tests.test_actions_openstack_upgrade.TestSwiftStorageUpgradeActions.test_openstack_upgrade_true [0.101551s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_ok [0.002746s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_day_plus_lag [0.004006s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_null_failures [0.010429s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_unknown_urlerror [0.001066s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_unknown_valueerror1 [0.001205s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_warn_lag [0.005436s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_no_upgrade_available [0.171317s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_upgrade_available [0.134037s] ... ok
{0} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_rsync_context_ipv6 [0.076800s] ... ok
{2} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_prunepath [0.119893s] ... ok
{0} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_swift_storage_context_missing_data [0.075189s] ... ok
{2} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_joined_multi_device [0.109164s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_changed_missing_relation_data [0.152119s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_nrpe_master [0.189012s] ... ok
{0} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_changed_with_relation_data [0.090959s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_joined_dev_exists_unknown_juju_env_uuid [0.084199s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_with_openstack_upgrade_action [0.134449s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_assert_charm_supports_ipv6 [0.161125s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_upgrade_charm [0.100919s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_guess_dev [0.156733s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_duplicate_dev [0.086975s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_main_hook_missing [0.106782s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_assert_charm_not_supports_ipv6 [0.102933s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_ensure_swift_directories [0.077784s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_no_config [0.122304s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_joined_single_device_juju_1 [0.125891s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_find_block_devices [0.076908s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_with_missing [0.072452s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_guess_dev_not_eligable [0.137592s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_do_upgrade [0.079750s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_grant_access [0.083119s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_get_device_blkid [0.078063s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_joined_single_device_juju_2 [0.142848s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_find_block_devices_real_world [0.088839s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_img [0.091725s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_register_configs_post_install [0.086376s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_revoke_access [0.073119s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_multi_dev [0.113722s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_img_reuse_fstab_entry [0.087742s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_encrypt [0.088056s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_save_script_rc [0.075214s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_swift_init_nonfatal [0.084111s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_single_dev [0.110338s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_encrypt_noready [0.089108s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_swift_init_fatal [0.079646s] ... ok
{2} unit_tests.test_templates.StorageServerTemplateTestCase.test_os_release_not_in_templates [0.093267s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_fetch_swift_rings [0.115907s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_overwrite [0.136028s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_register_configs_pre_install [0.070318s] ... ok
{2} unit_tests.test_templates.StorageServerTemplateTestCase.test_statsd_config_for_all_releases_and_servers [0.124975s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_no_chmod_existing_devs [0.068857s] ... ok
{1} unit_tests.test_templates.StorageServerTemplateTestCase.test_config_renders_for_all_releases_and_servers [0.090109s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_no_overwrite [0.100074s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_ufw [0.080996s] ... FAILED

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/root/TEST/charm-swift-storage/.tox/py35/lib/python3.5/site-packages/mock/mock.py", line 1330, in patched'
    b' return func(*args, **keywargs)'
    b' File "/root/TEST/charm-swift-storage/unit_tests/test_swift_storage_utils.py", line 648, in test_setup_ufw'
    b' mock_grant_access.assert_has_calls(calls)'
    b' File "/root/TEST/charm-swift-storage/.tox/py35/lib/python3.5/site-packages/mock/mock.py", line 978, in assert_has_calls'
    b' ), cause)'
    b' File "<string>", line 3, in raise_from'
    b'AssertionError: Calls not found.'
    b"Expected: [call('10.1.1.1', 6660),"
    b" call('10.1.1.1', 6661),"
    b" call('10.1.1.1', 6662),"
    b" call('10.1.1.2', 6660),"
    b" call('10.1.1.2', 6661),"
    b" call('10.1.1.2', 6662),"
    b" call('10.3.3.1', 6660),"
    b" call('10.3.3.1', 6661),"
    b" call('10.3.3.1', 6662),"
    b" call('10.3.3.2', 6660),"
    b" call('10.3.3.2', 6661),"
    b" call('10.3.3.2', 6662),"
    b" call('10.3.3.3', 6660),"
    b" call('10.3.3.3', 6661),"
    b" call('10.3.3.3', 6662),"
    b" call('91.189.94.40', 6660),"
    b" call('91.189.94.40', 6661),"
    b" call('91.189.94.40', 6662)]"
    b"Actual: [call('10.1.1.1', 6660),"
    b" call('10.1.1.1', 6661),"
    b" call('10.1.1.1', 6662),"
    b" call('10.1.1.2', 6660),"
    b" call('10.1.1.2', 6661),"
    b" call('10.1.1.2', 6662),"
    b" call('10.3.3.1', 6660),"
    b" call('10.3.3.1', 6661),"
    b" call('10.3.3.1', 6662),"
    b" call('10.3.3.2', 6660),"
    b" call('10.3.3.2', 6661),"
    b" call('10.3.3.2', 6662),"
    b" call('10.3.3.3', 6660),"
    b" call('10.3.3.3', 6661),"
    b" call('10.3.3.3', 6662),"
    b" call('91.189.89.118', 6660),"
    b" call('91.189.89.118', 6661),"
    b" call('91.189.89.118', 6662)]."
    b''

==============================
Failed 1 tests - output below:
==============================

unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_ufw
-------------------------------------------------------------------------

======
Totals
======
Ran: 87 tests in 1.9046 sec.
- Passed: 86
- Skipped: 0
- Expected Fail: 0
- Unexpected Success: 0
- Failed: 1
Sum of execute time for each test: 6.7181 sec.

==============
Worker Balance
==============
- Worker 0 (22 tests) => 0:00:01.509565
- Worker 1 (22 tests) => 0:00:01.727121
- Worker 2 (22 tests) => 0:00:01.673105
- Worker 3 (21 tests) => 0:00:01.852776
ERROR: InvocationError: '/root/TEST/charm-swift-storage/.tox/py35/bin/stestr run'
py36 create: /root/TEST/charm-swift-storage/.tox/py36
py36 installdeps: -r/root/TEST/charm-swift-storage/requirements.txt, -r/root/TEST/charm-swift-storage/test-requirements.txt
py36 installed: appdirs==1.4.3,asn1crypto==0.24.0,attrs==19.1.0,Babel==2.7.0,blessings==1.6,certifi==2019.3.9,cffi==1.12.3,chardet==3.0.4,charm-tools==2.6.0,charmhelpers==0.19.13,Cheetah3==3.2.3,cliff==2.15.0,cmd2==0.9.12,colander==1.7.0,colorama==0.4.1,coverage==4.5.3,cryptography==2.7,debtcollector==1.21.0,decorator==4.4.0,dict2colander==0.2,distro==1.4.0,distro-info==0.0.0,dnspython==1.16.0,dogpile.cache==0.7.1,entrypoints==0.3,extras==1.0.0,fixtures==3.0.0,flake8==2.4.1,future==0.17.1,httplib2==0.13.0,idna==2.8,importlib-metadata==0.18,iso8601==0.1.12,Jinja2==2.10.1,jmespath==0.9.4,jsonpatch==1.23,jsonpointer==2.0,jsonschema==2.5.1,jujubundlelib==0.5.6,keyring==19.0.2,keystoneauth1==3.14.0,launchpadlib==1.10.7,lazr.restfulclient==0.14.2,lazr.uri==1.0.3,libcharmstore==0.0.9,linecache2==1.0.0,macaroonbakery==1.2.3,MarkupSafe==1.1.1,mccabe==0.3.1,mock==3.0.5,msgpack==0.6.1,munch==2.3.2,netaddr==0.7.19,netifaces==0.10.9,oauthlib==3.0.1,openstacksdk==0.31.1,os-client-config==1.32.0,os-service-types==1.7.0,osc-lib==1.12.1,oslo.config==6.10.0,oslo.context==2.22.1,oslo.i18n==3.23.1,oslo.log==3.44.0,oslo.serialization==2.29.1,oslo.utils==3.41.0,otherstuf==1.1.0,parse==1.12.0,path.py==12.0.1,pathspec==0.3.4,pbr==1.8.1,pep8==1.7.1,pika==0.13.1,pkg-resources==0.0.0,prettytable==0.7.2,protobuf==3.8.0,psutil==1.2.1,pycparser==2.19,pyflakes==0.8.1,pyinotify==0.9.6,pymacaroons==0.13.0,PyNaCl==1.3.0,pyOpenSSL==19.0.0,pyparsing==2.4.0,pyperclip==1.7.0,pyRFC3339==1.1,python-ceilometerclient==2.9.0,python-cinderclient==4.2.0,python-dateutil==2.8.0,python-glanceclient==2.16.0,python-heatclient==1.17.0,python-keystoneclient==3.19.0,python-mimeparse==1.6.0,python-neutronclient==6.12.0,python-novaclient==14.1.0,python-openstackclient==3.19.0,python-subunit==1.3.0,python-swiftclient==3.7.0,pytz==2019.1,pyudev==0.21.0,PyYAML==3.13,requests==2.22.0,requestsexceptions==1.4.0,rfc3986==1.3.2,ruamel.yaml==0.15.97,SecretStorage==2.3.1,simplejson==3.16.0,six==1.12.0,stestr==2.3.1,stevedore==1.30.1,stuf==0.9.16,Tempita==0.5.2,testresources==2.0.1,testtools==2.3.0,theblues==0.5.1,traceback2==1.4.0,translationstring==1.3,unittest2==1.1.0,urllib3==1.25.3,vergit==1.0.2,virtualenv==16.6.0,voluptuous==0.11.5,wadllib==1.3.3,warlock==1.3.3,wcwidth==0.1.7,wrapt==1.11.1,zipp==0.5.1
py36 runtests: PYTHONHASHSEED='0'
py36 runtests: commands[0] | stestr run
juju-log: INFO: Block device "/tmp/tmpcoaxwzif/null_link" is a symlink to "/dev/null". Using "/dev/null".
{2} unit_tests.test_actions.MainTestCase.test_invokes_pause [0.062295s] ... ok
{2} unit_tests.test_actions_openstack_upgrade.TestSwiftStorageUpgradeActions.test_openstack_upgrade_false [0.072018s] ... ok
{2} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_swift_storage_context_with_data [0.032952s] ... ok
{2} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_no_upgrade_available [0.048331s] ... ok
{2} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_changed_missing_relation_data [0.038066s] ... ok
{2} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_joined_multi_device [0.041408s] ... ok
{2} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_upgrade_charm [0.040830s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_duplicate_dev [0.044377s] ... ok
{3} unit_tests.test_actions.MainTestCase.test_unknown_action [0.045457s] ... ok
{1} unit_tests.test_actions.MainTestCase.test_failing_action [0.045462s] ... ok
{0} unit_tests.test_actions.GetActionParserTestCase.test_definition_from_yaml [0.414828s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_fetch_swift_rings [0.072080s] ... ok
{1} unit_tests.test_actions.PauseTestCase.test_pauses_services [0.064306s] ... ok
{3} unit_tests.test_actions.PauseTestCase.test_pause_sets_value [0.065180s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_crit_md5sum_mismatch [0.001346s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_unknown_valueerror1 [0.000708s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_day_plus_lag [0.002110s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_failures [0.002212s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_null_failures [0.002253s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_ok [0.002344s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_unknown_valueerror1 [0.000638s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_unknown_valueerror2 [0.001196s] ... ok
{1} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_warn_failures [0.003612s] ... ok
{1} unit_tests.test_misc_utils.EnsureBlockDeviceTestCase.test_symlinks_are_resolved [0.005088s] ... ok
{0} unit_tests.test_actions.PauseTestCase.test_bails_out_early_on_error [0.059451s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_find_block_devices [0.067618s] ... ok
{3} unit_tests.test_actions.ResumeTestCase.test_bails_out_early_on_error [0.049817s] ... ok
{1} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_rsync_context [0.051142s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_main_hook_missing [0.058613s] ... ok
{1} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_rsync_context_ipv6 [0.054381s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_register_configs_pre_install [0.120986s] ... ok
{0} unit_tests.test_actions.ResumeTestCase.test_resume_sets_value [0.140000s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_prunepath [0.071935s] ... ok
{1} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_rsync_enable_rsync [0.073971s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_changed_with_relation_data [0.066533s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_save_script_rc [0.095942s] ... ok
{0} unit_tests.test_actions.ResumeTestCase.test_resumes_services [0.091060s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_add_ufw_gre_rule [0.064871s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_joined_dev_exists_unknown_juju_env_uuid [0.066924s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_ipv6 [0.072514s] ... ok
juju-log: Upgrading OpenStack release
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_encrypt_noready [0.096678s] ... ok
{0} unit_tests.test_actions_openstack_upgrade.TestSwiftStorageUpgradeActions.test_openstack_upgrade_true [0.096584s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_ok [0.004384s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_unknown_ioerror [0.005530s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_unknown_urlerror [0.001483s] ... ok
{3} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_joined_single_device_juju_1 [0.069395s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_md5_unknown_valueerror2 [0.001594s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_lag [0.002819s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_crit_lag_notworking [0.003334s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_unknown_urlerror [0.000677s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_check_replication_warn_lag [0.015246s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_with_openstack_upgrade_action [0.080590s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_generate_md5 [0.036120s] ... ok
{0} unit_tests.test_check_swift_storage.CheckSwiftStorageTestCase.test_repl_last_timestamp [0.000764s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_assert_charm_supports_ipv6 [0.069674s] ... ok
{1} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_install_hook [0.071513s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_overwrite [0.153414s] ... ok
{0} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_swift_storage_context_missing_data [0.086437s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_guess_dev [0.083243s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_single_dev [0.066510s] ... ok
{0} unit_tests.test_swift_storage_context.SwiftStorageContextTests.test_swift_storage_server_context [0.072782s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_guess_dev_not_eligable [0.070040s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_with_missing [0.062012s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_swift_init_fatal [0.134165s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_do_upgrade [0.072711s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_grant_access [0.065030s] ... ok
{0} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_nrpe_master [0.095486s] ... ok
{2} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_swift_init_nonfatal [0.077516s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_ensure_swift_directories [0.064387s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_encrypt [0.066342s] ... ok
{0} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_config_changed_upgrade_available [0.088281s] ... ok
{2} unit_tests.test_templates.StorageServerTemplateTestCase.test_config_renders_for_all_releases_and_servers [0.093925s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_find_block_devices_real_world [0.082030s] ... ok
{1} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_ufw [0.098700s] ... FAILED

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/root/TEST/charm-swift-storage/.tox/py36/lib/python3.6/site-packages/mock/mock.py", line 1330, in patched'
    b' return func(*args, **keywargs)'
    b' File "/root/TEST/charm-swift-storage/unit_tests/test_swift_storage_utils.py", line 648, in test_setup_ufw'
    b' mock_grant_access.assert_has_calls(calls)'
    b' File "/root/TEST/charm-swift-storage/.tox/py36/lib/python3.6/site-packages/mock/mock.py", line 978, in assert_has_calls'
    b' ), cause)'
    b' File "<string>", line 3, in raise_from'
    b'AssertionError: Calls not found.'
    b"Expected: [call('10.1.1.1', 6660),"
    b" call('10.1.1.1', 6661),"
    b" call('10.1.1.1', 6662),"
    b" call('10.1.1.2', 6660),"
    b" call('10.1.1.2', 6661),"
    b" call('10.1.1.2', 6662),"
    b" call('10.3.3.1', 6660),"
    b" call('10.3.3.1', 6661),"
    b" call('10.3.3.1', 6662),"
    b" call('10.3.3.2', 6660),"
    b" call('10.3.3.2', 6661),"
    b" call('10.3.3.2', 6662),"
    b" call('10.3.3.3', 6660),"
    b" call('10.3.3.3', 6661),"
    b" call('10.3.3.3', 6662),"
    b" call('91.189.94.40', 6660),"
    b" call('91.189.94.40', 6661),"
    b" call('91.189.94.40', 6662)]"
    b"Actual: [call('10.1.1.1', 6660),"
    b" call('10.1.1.1', 6661),"
    b" call('10.1.1.1', 6662),"
    b" call('10.1.1.2', 6660),"
    b" call('10.1.1.2', 6661),"
    b" call('10.1.1.2', 6662),"
    b" call('10.3.3.1', 6660),"
    b" call('10.3.3.1', 6661),"
    b" call('10.3.3.1', 6662),"
    b" call('10.3.3.2', 6660),"
    b" call('10.3.3.2', 6661),"
    b" call('10.3.3.2', 6662),"
    b" call('10.3.3.3', 6660),"
    b" call('10.3.3.3', 6661),"
    b" call('10.3.3.3', 6662),"
    b" call('91.189.90.58', 6660),"
    b" call('91.189.90.58', 6661),"
    b" call('91.189.90.58', 6662)]."
    b''
{0} unit_tests.test_swift_storage_relations.SwiftStorageRelationsTests.test_storage_joined_single_device_juju_2 [0.100731s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_register_configs_post_install [0.112017s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_assert_charm_not_supports_ipv6 [0.084538s] ... ok
{1} unit_tests.test_templates.StorageServerTemplateTestCase.test_os_release_not_in_templates [0.143253s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_revoke_access [0.058994s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_multi_dev [0.048977s] ... ok
{1} unit_tests.test_templates.StorageServerTemplateTestCase.test_statsd_config_for_all_releases_and_servers [0.066337s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_determine_block_device_no_config [0.045522s] ... ok
{3} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_no_overwrite [0.069574s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_get_device_blkid [0.060845s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_img [0.060672s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_img_reuse_fstab_entry [0.045917s] ... ok
{0} unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_storage_no_chmod_existing_devs [0.060356s] ... ok

==============================
Failed 1 tests - output below:
==============================

unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests.test_setup_ufw
-------------------------------------------------------------------------

======
Totals
======
Ran: 87 tests in 1.7807 sec.
- Passed: 86
- Skipped: 0
- Expected Fail: 0
- Unexpected Success: 0
- Failed: 1
Sum of execute time for each test: 5.3620 sec.

==============
Worker Balance
==============
- Worker 0 (27 tests) => 0:00:01.742857
- Worker 1 (26 tests) => 0:00:01.177629
- Worker 2 (17 tests) => 0:00:01.306838
- Worker 3 (17 tests) => 0:00:01.184789
ERROR: InvocationError: '/root/TEST/charm-swift-storage/.tox/py36/bin/stestr run'
_________________________________________________________________________________________________ summary __________________________________________________________________________________________________
pep8: commands succeeded
py27: commands succeeded
ERROR: py35: commands failed
ERROR: py36: commands failed

Has the IP address of "ubuntu.com" changed recently?

Tags:

Revision history for this message

Tytus Kurek (tkurek) wrote on 2019-06-14:

This is the current pool:

$ dig ubuntu.com | egrep -v ";ubuntu.com." | grep IN | awk '{print $5}'
91.189.89.110
91.189.90.58
91.189.89.118
91.189.90.59
91.189.89.103
91.189.89.115

but I think we should avoid hard-coding public IP addresses anyway.

Revision history for this message

Alex Kavanagh (ajkavanagh) wrote on 2019-06-14:

To fix this, the unit test shouldn't be accessing a resource outside of the test environment, so the IP addresses can be hardcoded, but they should be mocked properly in the test.

Changed in charm-swift-storage:
status:	New → Confirmed
importance:	Undecided → High

Alex Kavanagh (ajkavanagh) on 2019-06-14

Changed in charm-swift-storage:
assignee:	nobody → Alex Kavanagh (ajkavanagh)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-14: Fix proposed to charm-swift-storage (master)

Fix proposed to branch: master
Review: https://review.opendev.org/665401

Changed in charm-swift-storage:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-17: Fix merged to charm-swift-storage (master)

Reviewed: https://review.opendev.org/665401
Committed: https://git.openstack.org/cgit/openstack/charm-swift-storage/commit/?id=c9b558b0ff253c4fc7665c8dfd95ae58d713bc74
Submitter: Zuul
Branch: master

commit c9b558b0ff253c4fc7665c8dfd95ae58d713bc74
Author: Alex Kavanagh <email address hidden>
Date: Fri Jun 14 15:11:04 2019 +0100

Ensure that get_host_ip() is mocked out in test

    The test test_setup_ufw() didn't mock out get_host_ip() which meant that
    the test leaked and used an actual IP hostname lookup. This failed when
    ubuntu.com's IP address changed. This patch mocks it out properly.

Change-Id: Ida7aaa7d085cc0316aa496d0a0e24333c5828cee
Closes-Bug: #1832829

Changed in charm-swift-storage:
status:	In Progress → Fix Committed

James Page (james-page) on 2019-08-07

Changed in charm-swift-storage:
milestone:	none → 19.07

David Ames (thedac) on 2019-08-12

Changed in charm-swift-storage:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.