install hook fails under bionic re ufw

[Andrew McLeod]

Install hook fails - no such file or directory when trying to modify ufw permissions

the preseed for this lpar removes ufw, so the charm is attempting to make changes to ufw without ensuring it is installed. To verify this, apt-get install ufw, resolve the hook error, and the install hook works ok.

Install hook failure:

https://pastebin.canonical.com/p/3vCXGrzFT3/

[Frode Nordahl (fnordahl)]

Could you share any details about which architecture this is run on and whether it is deployed in a VM or LXD container?

[Andrew McLeod (admcleod)]

In this case its deployed directly to 'bare metal' (s390x LPAR) - in this particular case I am manually uninstalling ufw, so it may very well be a rare edge case. Still, it seems like the charm should deal with that without an error.

I have also repasted the log in public pastebin

https://paste.ubuntu.com/p/5zxC9c7WNg/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/565557

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Ames (<email address hidden>) on branch: master
Review: https://review.openstack.org/565557
Reason: Superseded by another PR.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566001
Committed: https://git.openstack.org/cgit/openstack/charm-swift-storage/commit/?id=18d0a891db6e794d3ddabf2ff45f4acf80283094
Submitter: Zuul
Branch: master

commit 18d0a891db6e794d3ddabf2ff45f4acf80283094
Author: David Ames <email address hidden>
Date: Tue May 1 10:14:54 2018 -0700

    Allow GRE traffic in converged architecture

    In a converged architecture with storage and compute on the same
    host, UFW can get in the way of tunneled traffic interpreting it as
    INVALID. UFW makes solving this more difficult than it needs to be.
    See http://northernmost.org/blog/gre-tunnels-and-ufw/index.html for
    context.

    This change updates /etc/ufw/before.rules to add GRE as an allowed
    input.

    Also, guarantee ufw is installed for LP #1763716

    Please review and merge charm-helpers first:
    https://github.com/juju/charm-helpers/pull/170

    Change-Id: I789854c33e3af12f7412633dbf7c921beb0ed2b5
    Closes-Bug: #1757564
    Closes-Bug: #1763716