OpenStack charms should handle pre-upgrade package refreshes

[Andrea Ieri]

The upgrade guide[0] asks operators to run `apt update && apt full-upgrade` prior to starting a cloud upgrade, since upgrade QA tests are run starting from whichever deb versions were current at the time of the test.

Given that all OpenStack charms must be able to execute those actions in order to execute the upgrade (after having updated the apt sources), they could also automate the initial refresh, after the user has requested an upgrade, right before modifying the apt sources.
Any disruption caused by automated minor version package upgrade would not really matter since it would immediately precede the expected disruption caused by the requested major version upgrade.

nova-compute and ceph-osd are often colocated, so special care should be exercised to limit the refresh to only the debs belonging to the application undergoing the upgrade (although shared dependencies would still be caught in the process). This could be done by replacing the `apt full-upgrade` with a suitable `apt install <package list>`, and is indeed already how ceph-osd performs its upgrade (though notably not nova-compute):

```
2680 def upgrade_osd(new_version, kick_function=None):
2681 """Upgrades the current OSD
2682
2683 :param new_version: str. The new version to upgrade to
2684 """
[...]
2704 try:
2705 # Upgrade the packages before restarting the daemons.
2706 status_set('maintenance', 'Upgrading packages to %s' % new_version)
2707 apt_install(packages=determine_packages(), fatal=True)
```

This request of course affects all OpenStack charms.

[0] https://docs.openstack.org/charm-guide/latest/admin/upgrades/openstack.html#ensure-cloud-node-software-is-up-to-date

[Peter Matulis (petermatulis)]

As of now, the Charm Guide accurately describes what is needed on the part of the user. There is no bug there. I am going to therefore remove the charm-guide bug task.